improve: showcase initialized spec deleted when adding finalizer with SSA with same fieldManager (operator-framework#2847)

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

Author: csviri

operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/ssaissue/finalizer/SSAFinalizerIssueCustomResource.java

@@ -0,0 +1,13 @@
+package io.javaoperatorsdk.operator.baseapi.ssaissue.finalizer;
+
+import io.fabric8.kubernetes.api.model.Namespaced;
+import io.fabric8.kubernetes.client.CustomResource;
+import io.fabric8.kubernetes.model.annotation.Group;
+import io.fabric8.kubernetes.model.annotation.ShortNames;
+import io.fabric8.kubernetes.model.annotation.Version;
+
+@Group("sample.javaoperatorsdk")
+@Version("v1")
+@ShortNames("ssfi")
+public class SSAFinalizerIssueCustomResource
+    extends CustomResource<SSAFinalizerIssueSpec, SSAFinalizerIssueStatus> implements Namespaced {}

operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/ssaissue/finalizer/SSAFinalizerIssueIT.java

@@ -0,0 +1,66 @@
+package io.javaoperatorsdk.operator.baseapi.ssaissue.finalizer;
+
+import java.util.List;
+
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.RegisterExtension;
+
+import io.fabric8.kubernetes.api.model.ObjectMetaBuilder;
+import io.fabric8.kubernetes.client.dsl.base.PatchContext;
+import io.fabric8.kubernetes.client.dsl.base.PatchType;
+import io.javaoperatorsdk.operator.junit.LocallyRunOperatorExtension;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.awaitility.Awaitility.await;
+
+class SSAFinalizerIssueIT {
+
+  public static final String TEST_1 = "test1";
+
+  @RegisterExtension
+  LocallyRunOperatorExtension extension =
+      LocallyRunOperatorExtension.builder()
+          .withReconciler(new SSAFinalizerIssueReconciler())
+          .build();
+
+  /**
+   * Showcases possibly a case with SSA: When the resource is created with the same field manager
+   * that used by the controller, when adding a finalizer, it deletes other parts of the spec.
+   */
+  @Test
+  void addingFinalizerRemoveListValues() {
+    var fieldManager =
+        extension
+            .getRegisteredControllerForReconcile(SSAFinalizerIssueReconciler.class)
+            .getConfiguration()
+            .fieldManager();
+
+    extension
+        .getKubernetesClient()
+        .resource(testResource())
+        .inNamespace(extension.getNamespace())
+        .patch(
+            new PatchContext.Builder()
+                .withFieldManager(fieldManager)
+                .withForce(true)
+                .withPatchType(PatchType.SERVER_SIDE_APPLY)
+                .build());
+
+    await()
+        .untilAsserted(
+            () -> {
+              var actual = extension.get(SSAFinalizerIssueCustomResource.class, TEST_1);
+              assertThat(actual.getFinalizers()).hasSize(1);
+              assertThat(actual.getSpec()).isNull();
+            });
+  }
+
+  SSAFinalizerIssueCustomResource testResource() {
+    var res = new SSAFinalizerIssueCustomResource();
+    res.setMetadata(new ObjectMetaBuilder().withName(TEST_1).build());
+    res.setSpec(new SSAFinalizerIssueSpec());
+    res.getSpec().setValue("val");
+    res.getSpec().setList(List.of("val1", "val2"));
+    return res;
+  }
+}

operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/ssaissue/finalizer/SSAFinalizerIssueReconciler.java

@@ -0,0 +1,26 @@
+package io.javaoperatorsdk.operator.baseapi.ssaissue.finalizer;
+
+import io.javaoperatorsdk.operator.api.reconciler.Cleaner;
+import io.javaoperatorsdk.operator.api.reconciler.Context;
+import io.javaoperatorsdk.operator.api.reconciler.ControllerConfiguration;
+import io.javaoperatorsdk.operator.api.reconciler.DeleteControl;
+import io.javaoperatorsdk.operator.api.reconciler.Reconciler;
+import io.javaoperatorsdk.operator.api.reconciler.UpdateControl;
+
+@ControllerConfiguration
+public class SSAFinalizerIssueReconciler
+    implements Reconciler<SSAFinalizerIssueCustomResource>,
+        Cleaner<SSAFinalizerIssueCustomResource> {
+
+  @Override
+  public DeleteControl cleanup(
+      SSAFinalizerIssueCustomResource resource, Context<SSAFinalizerIssueCustomResource> context) {
+    return DeleteControl.defaultDelete();
+  }
+
+  @Override
+  public UpdateControl<SSAFinalizerIssueCustomResource> reconcile(
+      SSAFinalizerIssueCustomResource resource, Context<SSAFinalizerIssueCustomResource> context) {
+    return UpdateControl.noUpdate();
+  }
+}

operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/ssaissue/finalizer/SSAFinalizerIssueSpec.java

@@ -0,0 +1,26 @@
+package io.javaoperatorsdk.operator.baseapi.ssaissue.finalizer;
+
+import java.util.List;
+
+public class SSAFinalizerIssueSpec {
+
+  private String value;
+
+  private List<String> list = null;
+
+  public String getValue() {
+    return value;
+  }
+
+  public void setValue(String value) {
+    this.value = value;
+  }
+
+  public List<String> getList() {
+    return list;
+  }
+
+  public void setList(List<String> list) {
+    this.list = list;
+  }
+}

operator-framework/src/test/java/io/javaoperatorsdk/operator/baseapi/ssaissue/finalizer/SSAFinalizerIssueStatus.java

@@ -0,0 +1,19 @@
+package io.javaoperatorsdk.operator.baseapi.ssaissue.finalizer;
+
+public class SSAFinalizerIssueStatus {
+
+  private String configMapStatus;
+
+  public String getConfigMapStatus() {
+    return configMapStatus;
+  }
+
+  public void setConfigMapStatus(String configMapStatus) {
+    this.configMapStatus = configMapStatus;
+  }
+
+  @Override
+  public String toString() {
+    return "TestCustomResourceStatus{" + "configMapStatus='" + configMapStatus + '\'' + '}';
+  }
+}