refactor: use viewIDs computed property instead of Object.keys(viewByID)

Author: PaulHax

src/composables/useSyncWindowing.ts

@@ -13,7 +13,7 @@ export function useSyncWindowing() {
     isUpdating = true;
     try {
       const config = windowingStore.getConfig(viewID, dataID);
-      Object.keys(viewStore.viewByID)
+      viewStore.viewIDs
         .filter((id) => id !== viewID)
         .forEach((vid) => {
           windowingStore.updateConfig(vid, dataID, config);

src/store/tools/paint.ts

@@ -57,7 +57,7 @@ export const usePaintToolStore = defineStore('paint', () => {
   const currentViewIDs = computed(() => {
     const imageID = unref(currentImageID);
     if (imageID) {
-      return Object.keys(viewStore.viewByID).filter(
+      return viewStore.viewIDs.filter(
         (viewID) => !!viewSliceStore.getConfig(viewID, imageID)
       );
     }

src/store/view-configs/common.ts

@@ -24,7 +24,11 @@ const serializeViewConfig = <
           // eslint-disable-next-line no-param-reassign
           view.config = {};
         }
-        const configForData = ensureDefault(dataID, view.config, {} as ViewConfig);
+        const configForData = ensureDefault(
+          dataID,
+          view.config,
+          {} as ViewConfig
+        );
         configForData[viewConfigStateKey] = viewConfig as ViewConfig[K];
       }
     });

src/store/views.ts

@@ -88,6 +88,8 @@ export const useViewStore = defineStore('view', () => {
     return views;
   });
 
+  const viewIDs = computed(() => Object.keys(viewByID));
+
   function getView(id: Maybe<string>) {
     if (!id) return null;
     return viewByID[id] ?? null;
@@ -175,7 +177,7 @@ export const useViewStore = defineStore('view', () => {
   }
 
   function setDataForAllViews(dataID: Maybe<string>) {
-    Object.keys(viewByID).forEach((viewID) => {
+    viewIDs.value.forEach((viewID) => {
       setDataForView(viewID, dataID);
     });
   }
@@ -206,7 +208,7 @@ export const useViewStore = defineStore('view', () => {
     isActiveViewMaximized.value = manifest.isActiveViewMaximized;
     layoutSlots.value = manifest.layoutSlots;
 
-    Object.keys(viewByID).forEach((key) => {
+    viewIDs.value.forEach((key) => {
       delete viewByID[key];
     });
 
@@ -218,25 +220,6 @@ export const useViewStore = defineStore('view', () => {
     });
   }
 
-  //     deserialize(views: View[], dataIDMap: Record<string, string>) {
-  //       const viewConfigStore = useViewConfigStore();
-
-  //       views.forEach((view) => {
-  //         const viewID = view.id;
-
-  //         const viewSpec = {
-  //           viewType: view.type,
-  //           props: view.props,
-  //         };
-
-  //         this.viewSpecs[viewID] = viewSpec;
-
-  //         // Now delegate the deserialization of the view config
-  //         const { config } = view;
-  //         viewConfigStore.deserialize(viewID, config, dataIDMap);
-  //       });
-  //     },
-
   // initialization
 
   DefaultLayoutSlots.forEach((viewInit) => {
@@ -253,6 +236,7 @@ export const useViewStore = defineStore('view', () => {
       return layout.value;
     }),
     visibleViews,
+    viewIDs,
     activeView,
     viewByID,
     getView,