Skip to content

Activation of air absorption #379

Description

@jordanalwon

Hi,

i found some discrepancies with the activation of air_absorption:
When using pra.Room.from_corners, the argument air_absorption=True can be set via initialization.
But to activate the air absorption at a different position in code I used the line room.air_absorption = True.
I already know that this is not the correct way to program this. To work properly I should use room.set_air_absorption()
I code on a Windows machine and run CI-tests on a linux server. I noticed room.air_absorption= True runs without an error on windows but raises TypeError: 'bool' object is not subscriptable on linux.

So I would suggest that the variable air_absorption of room should be a property without a setter method to prevent the use of room.air_absorption = True.
And do you have any idea why no error is raised when using Windows?

Metadata

Metadata

Assignees

Labels

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions