Question:
what is the intended mechanism today for setting containerd runtime overrides when using the tookit installer?
asking since there does still appear to be a --runtime-config-override flag, but seems to be an unintended artifact of #722 which followed its removal in a previous PR #643 (comment) with rationale that it was unnecessary complexity.
|
&cli.StringFlag{ |
|
Name: "runtime-config-override", |
|
Destination: &opts.runtimeConfigOverrideJSON, |
|
Usage: "specify additional runtime options as a JSON string. The paths are relative to the runtime config.", |
|
Value: "{}", |
|
Sources: cli.EnvVars("RUNTIME_CONFIG_OVERRIDE", "CONTAINERD_RUNTIME_CONFIG_OVERRIDE"), |
|
}, |
the "inheritance" mechanism which reads from the default or fallback runtime block works sufficiently well, but is tied closer to node infra/provisioning, which doesn't feel ideal for dynamic installations.
hoping to either re-introduce the --runtime-config-override feature or note down a recommended stance on how this should be done (and remove the dead code). maybe externally-managed containerd drop-in configs are the right way to go but then thats implicitly tied to the chosen NVIDIA_RUNTIME_NAME and whatnot.
Question:
what is the intended mechanism today for setting
containerdruntime overrides when using the tookit installer?asking since there does still appear to be a
--runtime-config-overrideflag, but seems to be an unintended artifact of #722 which followed its removal in a previous PR #643 (comment) with rationale that it was unnecessary complexity.nvidia-container-toolkit/cmd/nvidia-ctk-installer/container/runtime/containerd/containerd.go
Lines 78 to 84 in 357b970
the "inheritance" mechanism which reads from the default or fallback runtime block works sufficiently well, but is tied closer to node infra/provisioning, which doesn't feel ideal for dynamic installations.
hoping to either re-introduce the
--runtime-config-overridefeature or note down a recommended stance on how this should be done (and remove the dead code). maybe externally-managed containerd drop-in configs are the right way to go but then thats implicitly tied to the chosenNVIDIA_RUNTIME_NAMEand whatnot.