- Use
nix develop. - This project uses
docker composefor the development environment. - The development stack can be started using
docker compose up --build --detach.
- Use
one,onlyorfirstfrommore_itertoolsinstead of[0].
autogenerated_graphql_client/CANNOT be edited manually.- Use
ariadne-codegen clientifqueries.graphqlhas changed.
- Prefer integration tests over unit tests, and avoid using mocks.
- Use fixtures from
tests/conftest.pyandtests/integration/conftest.pywhen writing tests. - Never run
pytestdirectly on the host. - Always use
docker compose run --rm sdtool-plus pytest ...to run tests. This requires starting the development environment and runningdocker compose stop sdtool-plusfirst. - You will need a running os2mo stack to run integration tests, you can find os2mo here: https://github.com/OS2mo
- Never run all tests; it takes too long. Only run relevant tests.
- Branch names should include a ticket number, e.g.
69176-related-owner. - Make sure
pre-commit run --all-filespasses before committing. - Commits must adhere to the conventional commits style and include a ticket
number, e.g.:
feat: [#68002] allow reading connected addresses through an engagement.fix: [#68002] don't sleep when no events.
- You do not have access to the remote, so you can't look up the merge request/pull request
- Assume that you need to review the commits from the base of the branch to the head