feature/add getOtherBankAccountByNumber method to handle external bank accounts and create in-memory accounts for payments

Author: hongwei1

obp-api/src/main/scala/code/api/util/NewStyle.scala

@@ -450,6 +450,12 @@ object NewStyle extends MdcLoggable{
         (unboxFullOrFail(i._1, callContext, s"$BankAccountNotFound Current BankId is $bankId and Current AccountNumber is $accountNumber", 404), i._2)
       }
 
+    // this is for the bankAccount from external, maybe can not get any account, so we will create a in-memory account for payments.
+    def getOtherBankAccountByNumber(bankId : Option[BankId], accountNumber : String, counterparty: Option[CounterpartyTrait], callContext: Option[CallContext]) : OBPReturnType[(BankAccount)] = {
+      Connector.connector.vend.getOtherBankAccountByNumber(bankId, accountNumber, counterparty, callContext) } map { i =>
+        (unboxFullOrFail(i._1, callContext, s"$BankAccountNotFound Current BankId is $bankId and Current AccountNumber is $accountNumber", 404), i._2)
+      }
+
     def getBankSettlementAccounts(bankId: BankId, callContext: Option[CallContext]): OBPReturnType[List[BankAccount]] = {
       Connector.connector.vend.getBankSettlementAccounts(bankId: BankId, callContext: Option[CallContext]) map { i =>
         (unboxFullOrFail(i._1, callContext,s"$BankNotFound Current BankId is $bankId", 404 ), i._2)

obp-api/src/main/scala/code/bankconnectors/Connector.scala

@@ -530,6 +530,10 @@ trait Connector extends MdcLoggable {
 
   def getBankAccountByNumber(bankId : Option[BankId], accountNumber : String, callContext: Option[CallContext]) : OBPReturnType[Box[(BankAccount)]] = Future {(Failure(setUnimplementedError(nameOf(getBankAccountByNumber _))), callContext)}
 
+  // This method handles external bank accounts that may not exist in our database.
+  // If the account is not found, we create an in-memory account using counterparty information for payment processing.
+  def getOtherBankAccountByNumber(bankId : Option[BankId], accountNumber : String, counterparty: Option[CounterpartyTrait], callContext: Option[CallContext]) : OBPReturnType[Box[(BankAccount)]] = Future {(Failure(setUnimplementedError(nameOf(getOtherBankAccountByNumber _))), callContext)}
+
   def getBankAccountByRoutings(bankAccountRoutings: BankAccountRoutings, callContext: Option[CallContext]) : OBPReturnType[Box[(BankAccount)]] = Future {(Failure(setUnimplementedError(nameOf(getBankAccountByRoutings _))), callContext)}
 
   def getCounterpartyFromTransaction(bankId: BankId, accountId: AccountId, counterpartyId: String, callContext: Option[CallContext]): OBPReturnType[Box[Counterparty]] = Future {(Failure(setUnimplementedError(nameOf(checkBankAccountExists _))), callContext)}

obp-api/src/main/scala/code/bankconnectors/LocalMappedConnector.scala

@@ -1035,6 +1035,62 @@ object LocalMappedConnector extends Connector with MdcLoggable {
       }
     }
 
+  // this is for the bankAccount from external, maybe can not get any account, so we will create a in-memory account for payments.
+  override def getOtherBankAccountByNumber(bankId : Option[BankId], accountNumber : String, counterparty: Option[CounterpartyTrait], callContext: Option[CallContext]) : OBPReturnType[Box[(BankAccount)]] = 
+    Future {
+      // First try to get the account using existing method
+      val existingAccount = getBankAccountByNumber(bankId, accountNumber, callContext)
+      
+      Await.result(existingAccount, 5.seconds)._1 match {
+        case Full(account) => 
+          // If account found, return it
+          (Full(account), callContext)
+        case _ => 
+          // If account not found, create in-memory account from counterparty if available
+          counterparty match {
+            case Some(cp) =>
+              // Create in-memory account similar to BankingData.getBankAccountFromCounterparty
+              val accountRouting1 =
+                if (cp.otherAccountRoutingScheme.isEmpty) Nil
+                else List(AccountRouting(cp.otherAccountRoutingScheme, cp.otherAccountRoutingAddress))
+              val accountRouting2 =
+                if (cp.otherAccountSecondaryRoutingScheme.isEmpty) Nil
+                else List(AccountRouting(cp.otherAccountSecondaryRoutingScheme, cp.otherAccountSecondaryRoutingAddress))
+
+              // Due to the new field in the database, old counterparty have void currency, so by default, we set it to EUR
+              val counterpartyCurrency = if (cp.currency.nonEmpty) cp.currency else "EUR"
+
+              val inMemoryAccount = BankAccountCommons(
+                AccountId(if (cp.otherAccountSecondaryRoutingAddress.nonEmpty) cp.otherAccountSecondaryRoutingAddress else accountNumber), 
+                "", 0,
+                currency = counterpartyCurrency,
+                name = cp.name,
+                "", accountNumber, 
+                BankId(cp.otherBankRoutingAddress), 
+                new Date(), "",
+                accountRoutings = accountRouting1 ++ accountRouting2,
+                List.empty, 
+                accountHolder = cp.name,
+                Some(List(Attribute(
+                  name = "BANK_ROUTING_SCHEME",
+                  `type` = "STRING",
+                  value = cp.otherBankRoutingScheme
+                ),
+                  Attribute(
+                    name = "BANK_ROUTING_ADDRESS",
+                    `type` = "STRING",
+                    value = cp.otherBankRoutingAddress
+                  ),
+                ))
+              )
+              (Full(inMemoryAccount), callContext)
+            case None =>
+              // No counterparty provided, return failure
+              (Failure(s"$InvalidAccountNumber, current AccountNumber is $accountNumber and no counterparty provided for creating in-memory account"), callContext)
+          }
+      }
+    }
+
   override def getBankAccountByRoutings(
     bankAccountRoutings: BankAccountRoutings,
     callContext: Option[CallContext]