Skip to content

Commit a93d518

Browse files
committed
refactor/update RabbitMQConnectionPool to use typed GenericObjectPoolConfig and add commons-pool2 dependency
1 parent 2a7f039 commit a93d518

2 files changed

Lines changed: 10 additions & 8 deletions

File tree

‎obp-api/pom.xml‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,11 @@
184184
<artifactId>httpclient</artifactId>
185185
<version>4.5.13</version>
186186
</dependency>
187+
<dependency>
188+
<groupId>org.apache.commons</groupId>
189+
<artifactId>commons-pool2</artifactId>
190+
<version>2.11.1</version>
191+
</dependency>
187192
<dependency>
188193
<groupId>org.eclipse.jetty</groupId>
189194
<artifactId>jetty-util</artifactId>

‎obp-api/src/main/scala/code/bankconnectors/rabbitmq/RabbitMQConnectionPool.scala‎

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,11 @@ package code.bankconnectors.rabbitmq
22

33

44

5-
import code.api.util.APIUtil
6-
import com.rabbitmq.client.{Connection, ConnectionFactory}
7-
import org.apache.commons.pool2.impl.{GenericObjectPool, GenericObjectPoolConfig}
8-
import org.apache.commons.pool2.BasePooledObjectFactory
9-
import org.apache.commons.pool2.PooledObject
10-
import org.apache.commons.pool2.impl.DefaultPooledObject
5+
import code.api.util.{APIUtil, ErrorMessages}
116
import code.bankconnectors.rabbitmq.RabbitMQUtils._
12-
import code.api.util.ErrorMessages
7+
import com.rabbitmq.client.{Connection, ConnectionFactory}
8+
import org.apache.commons.pool2.{BasePooledObjectFactory, PooledObject}
9+
import org.apache.commons.pool2.impl.{DefaultPooledObject, GenericObjectPool, GenericObjectPoolConfig}
1310

1411
class RabbitMQConnectionFactory extends BasePooledObjectFactory[Connection] {
1512

@@ -59,7 +56,7 @@ class RabbitMQConnectionFactory extends BasePooledObjectFactory[Connection] {
5956

6057
// Pool to manage RabbitMQ connections
6158
object RabbitMQConnectionPool {
62-
private val poolConfig = new GenericObjectPoolConfig()
59+
private val poolConfig = new GenericObjectPoolConfig[Connection]()
6360
poolConfig.setMaxTotal(5) // Maximum number of connections
6461
poolConfig.setMinIdle(2) // Minimum number of idle connections
6562
poolConfig.setMaxIdle(5) // Maximum number of idle connections

0 commit comments

Comments
 (0)