Skip to content

Commit f1344c1

Browse files
committed
refactor: remove dead activeResourceDocs identity match in resource-docs dispatcher
Every one of its ~19 arms was `case X => resourceDocs`, unchanged -- a leftover from the pre-http4s Lift route-filter era that stopped doing any filtering once the corresponding version moved fully onto http4s. getResourceDocsList now feeds resourceDocs directly into activePlusLocalResourceDocs, with identical output.
1 parent f1e9f4e commit f1344c1

1 file changed

Lines changed: 1 addition & 27 deletions

File tree

‎obp-api/src/main/scala/code/api/ResourceDocs1_4_0/ResourceDocsAPIMethods.scala‎

Lines changed: 1 addition & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -355,35 +355,9 @@ trait ResourceDocsAPIMethods extends MdcLoggable with APIMethods220 with APIMeth
355355

356356
logger.debug(s"There are ${resourceDocs.length} resource docs available to $requestedApiVersion")
357357

358-
val activeResourceDocs = requestedApiVersion match {
359-
case ApiVersion.v7_0_0 => resourceDocs
360-
case ConstantsBG.`berlinGroupVersion1` => resourceDocs // fully on http4s — no Lift route filter
361-
case ConstantsBG.`berlinGroupVersion2` => resourceDocs
362-
case ApiVersion.v1_2_1 => resourceDocs
363-
case ApiVersion.v6_0_0 => resourceDocs // fully on http4s — no Lift route filter
364-
case ApiVersion.v5_1_0 => resourceDocs // fully on http4s — no Lift route filter
365-
case ApiVersion.v5_0_0 => resourceDocs // fully on http4s — no Lift route filter
366-
case ApiVersion.v4_0_0 => resourceDocs // fully on http4s — no Lift route filter
367-
case ApiVersion.v3_1_0 => resourceDocs // fully on http4s — no Lift route filter
368-
case ApiVersion.v3_0_0 => resourceDocs // fully on http4s — no Lift route filter
369-
case ApiVersion.v2_2_0 => resourceDocs // fully on http4s — no Lift route filter
370-
case ApiVersion.v2_1_0 => resourceDocs // fully on http4s — no Lift route filter
371-
case ApiVersion.v2_0_0 => resourceDocs // fully on http4s — no Lift route filter
372-
case ApiVersion.v1_4_0 => resourceDocs // fully on http4s — no Lift route filter
373-
case ApiVersion.v1_3_0 => resourceDocs // fully on http4s — no Lift route filter
374-
case ApiVersion.`dynamic-entity` => resourceDocs // runtime CRUD now on Http4sDynamicEntity; routes are Nil, skip Lift-route filter
375-
case ApiVersion.`dynamic-endpoint` => resourceDocs // dispatch now on Http4sDynamicEndpoint (proxy + native Piece C); routes carry only the stub, skip Lift-route filter
376-
case ApiVersion.ukOpenBankingV20 => resourceDocs // fully on http4s — no Lift route filter
377-
case ApiVersion.ukOpenBankingV31 => resourceDocs // fully on http4s — no Lift route filter
378-
case _ => resourceDocs
379-
}
380-
381-
logger.debug(s"There are ${activeResourceDocs.length} resource docs available to $requestedApiVersion")
382-
383-
384358
val activePlusLocalResourceDocs = ArrayBuffer[ResourceDoc]()
385359

386-
activePlusLocalResourceDocs ++= activeResourceDocs
360+
activePlusLocalResourceDocs ++= resourceDocs
387361
requestedApiVersion match
388362
{
389363
// only `obp` standard show the `localResourceDocs`

0 commit comments

Comments
 (0)