You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
OED currently allows the use of a .env file and values set in the docker-compose.yml file. I think the idea may have been to allow easy override of the values via the .env. However, one can get a similar result by using a second docker config file to replace with the desired new values without changing the main docker config file. Also, having two locations of sensitive information seems less desirable and may make it harder when OED transitions to secure storage of these values.
Describe the solution you'd like
The proposal is the eliminate the .env file/usage and only use the docker-compose.yml file.
Describe alternatives you've considered
Leave as is.
Additional context
This is going to require finding and updating every place in OED that uses the .env file. Note this is likely separate from the env values from docker. I quickly looked at where env is done and found these files to consider (probably not a complete list):
Is your feature request related to a problem? Please describe.
OED currently allows the use of a .env file and values set in the docker-compose.yml file. I think the idea may have been to allow easy override of the values via the .env. However, one can get a similar result by using a second docker config file to replace with the desired new values without changing the main docker config file. Also, having two locations of sensitive information seems less desirable and may make it harder when OED transitions to secure storage of these values.
Describe the solution you'd like
The proposal is the eliminate the .env file/usage and only use the docker-compose.yml file.
Describe alternatives you've considered
Leave as is.
Additional context
This is going to require finding and updating every place in OED that uses the .env file. Note this is likely separate from the env values from docker. I quickly looked at where env is done and found these files to consider (probably not a complete list):