Skip to content

The attribute.json patch removes the value property, and references a non-existant "other_attributes table" in its description #18

Description

@mrshll1001

The patch for the attribute.json schema removes the value property, which is the main mechanism by which the attribute.json schema applies a value which isn't an instance of taxonomy_term.json.

This could be deliberate and the result of a desire to restrict the use of the attribute.json schema to only add taxonomy terms, but I felt it worth noting.

The patch also overrides the schema-level description property with the following:

The other_attributes table creates a link between entities other than service and one or more classifications that describe the entity.

I did a hunt around the profile and searched for instances of other_attributes via rg, but got no results; it's only ever mentioned as part of the description of the attribute schema.

I think it's worthwhile to re-add the attribute.value property and remove the override to the schema's description, or at least update it to remove the reference to a non-existant "table".

Also noting that this patch also removes the link_table property; but I think this is a good thing because this property is mostly a convoluted way to satisfy representing linking an individual instance of attribute.json to an arbitrary schema in a normalized representation.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions