Skip to content

Handler Changing not calling on windows causing memory leak. #72

Description

@ehoward0018
    {
        // TODO: If I do not comment this out, I get this exception on Android when I leave the app using the back button and then open the app again:
        // System.InvalidOperationException: 'Handler is already being set elsewhere'
        // But it is really weird because it looks like nothing is called in the OnHandlerChanging() method. Page do not even override it
        // There is also the HandlerChanging event for those who need to do something on handler changing
        // This situation overall causes problems - e.g. when I try to navigate deeper to the stack after coming back to the app, the app crashes with 'pending navigation' exception

        //base.OnHandlerChanging(args);

        SetDefaultShellPropertyValues();
        UpdateVisualStates();
        UpdateItemsCollections();
    }

I believe this section of SimpleShell is causing an issue on Windows where replacing the shell doesn't clean up the handlers. Could this please be re added and then just wrapped in a platform conditional until the Android issue is found?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions