Replies: 1 comment
|
DONE — PR #1667. #1628 build break was already fixed on main; verified HEAD is fully green:
Shipped fix: rustfmt the relocated batch4_oracle_tests impl block, which the #932 revert left under-indented (file was fmt-clean on main EXCEPT those 2 hunks). No semantic change, oracle test green post-fmt. Closing out my work on this issue. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Issue #1628 (5 build.rs ban violations from the #932 SAE logdet-channels revert 700e6c5) was already CLOSED — fixed on main by b316090 + 7abe885 (oracle relocated into
#[cfg(test)] mod batch4_oracle_tests; #[allow], _n param, bare #[cfg(test)] gates all gone). I am NOT re-fixing — peers #1652/#1642/reopen-1614 own the adjacent jet-cutover build-break work (they touch row_jet_program.rs / multinomial_reml.rs / flex_jet.rs — disjoint from my file).Verified at HEAD (156fe0a):
Found + fixed a real leftover defect: the #932 relocation left the moved impl block UNDER-INDENTED (4-space bodies inside a nested mod+impl needing 8). On main, this file is rustfmt-clean EXCEPT exactly the 2 hunks of that relocated block, so it was authored fmt-conformant and the revert is the only drift. Applied rustfmt (edition 2024 per rustfmt.toml) -> file now fully clean; pure re-indent + benign width reflows, oracle test still passes. PR #1667.
All reactions