Skip to content

Commit 1fddc81

Browse files
committed
ci: skip release-please on manual npm backfill dispatch
A backfill run must be a narrow npm-only operation. Without an event guard, workflow_dispatch also ran release-please with contents+PR write permissions and could create or advance a release PR as a side effect. npm-publish is unaffected: its !cancelled() condition tolerates the skipped need, and all other jobs already gate on release_created.
1 parent 62d73c4 commit 1fddc81

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

‎.github/workflows/release.yml‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,10 @@ permissions: {}
2424

2525
jobs:
2626
release-please:
27-
if: ${{ github.repository == 'Gitlawb/node' }}
27+
# Skipped on manual dispatch: a backfill must never create or advance a
28+
# release PR as a side effect (npm-publish tolerates the skipped need via
29+
# !cancelled(), and every other job gates on release_created == 'true').
30+
if: ${{ github.repository == 'Gitlawb/node' && github.event_name != 'workflow_dispatch' }}
2831
name: Release Please
2932
runs-on: ubuntu-latest
3033
permissions:

0 commit comments

Comments
 (0)