Repository navigation
Commit 30672cf
t
Address PR review feedback (#194)
- Create the node identity key atomically with create_new + mode 0600, closing
the umask-derived 0644 disclosure window and the exists()->write overwrite
race; on AlreadyExists load the winner's key (bounded retry so a loser can't
read a half-written PEM) and tighten looser perms on load.
- Enforce the configured shutdown grace: bound the axum drain by grace measured
from the signal (extracted as drive_serve_with_grace), abandoning in-flight
requests once it expires instead of waiting indefinitely. Removes the
discarded grace value.
- Route the deny-harness reqwest clients through a shared bounded_client (30s
timeout) so a wedged node path fails fast instead of hanging to the CI limit.
Tests: 0600-on-create, load-tighten, concurrent-start convergence (create race),
and grace-race abandon / normal-drain / signal-gated-clock. All RED-then-GREEN
by execution.1 parent 532627f commit 30672cf
2 files changed
Lines changed: 354 additions & 38 deletions
0 commit comments