[wf-locker] All widget icon size parameters (*_icon_size) are broken and ignored

[mrfoggg]

Describe the bug

*_icon_size parameters in wf-locker do not scale icons for any widget. While *_font correctly resizes text, icons remain locked at their default ~1em size regardless of the set value.

Config section ([locker])

[locker]
background_image = true
hide_time = 5.0
hide_anim = 2
hide_anim_dur = 0.4
prewake = 1.0
lockout_attempts = 5
lockout_timer = 10 

### PASSWORD ###
password_enable = true
password_position = center-center
password_always = true
password_font = 8em default  # IGNORED

### NETWORK ###
network_enable = true
network_position = top-right
network_always = true
network_font = 48px sans-serif
network_icon_size = 5.0  # IGNORED

### CLOCK ###
clock_enable = true
clock_position = top-center
clock_always = true
clock_format = %H:%M%n<span font-size='xx-small'>%e %b %Y</span>
clock_font = 5em default

### WEATHER ###
weather_enable = true
weather_position = bottom-left
weather_always = true
weather_font = 5em default
weather_icon_size = 30.0 # NO ICON

### USER ###
user_enable = true
user_position = center-center
user_always = true
user_font = 7em default
user_icon_size = 4.0  # IGNORED

### MPRIS ###
mpris_enable = true
mpris_position = bottom-right
mpris_always = false
mpris_format = Now Playing:%n%track%n%album%n%artist
mpris_control = true
mpris_icon_size = 5.0
mpris_font = 1em default

### BATTERY ###
battery_enable = true
battery_position = top-left
battery_always = true
battery_status = full
battery_percent_font = 3em default
battery_description_font = 1em default
battery_icon_size = 3.0  # IGNORED

### VOLUME ###
volume_enable = true
volume_position = top-left
volume_always = false
volume_icon_size = 7.0  # IGNORED

### INSTANT UNLOCK ###
instant_unlock_enable = false
instant_unlock_position = bottom-center
instant_unlock_always = false
instant_unlock_font = default

[trigg]

So I'm not experiencing this.

I run up a WF_LOCKER_DEBUG=1 wf-locker to get a windowed locker, and change each icon_size and it happens as I save the change.

As you also have custom CSS it might be worth checking if any rules might be overriding it at a higher priority

[mrfoggg]

I found the root cause by running WF_LOCKER_DEBUG=1 wf-locker!

It is a locale/floating-point formatting bug when generating internal GTK CSS rules for -gtk-icon-size.

In system locales that use a comma , instead of a dot . for decimals, wf-locker generates invalid GTK CSS strings like this:

(wf-locker:15090): Gtk-WARNING : Theme parser error: :1:45-46: Unit is missing.
.wf-locker image.weather {-gtk-icon-size:10,000000em;}

(wf-locker:15090): Gtk-WARNING : Theme parser error: :1:42-44: Unit is missing.
.wf-locker .battery-image {-gtk-icon-size:3,000000em;}

GTK fails to parse -gtk-icon-size: 3,000000em; because of the comma , and ignores the setting completely, falling back to default icon sizes.

The CSS generator for *_icon_size needs to force std::locale::classic() or format floats using LC_NUMERIC="C" / dot delimiter so it always outputs 3.000000em instead of 3,000000em.

[mrfoggg]

Confirmed! Running with LC_NUMERIC=C completely fixes the issue:

LC_NUMERIC=C WF_LOCKER_DEBUG=1 wf-locker

With LC_NUMERIC=C, GTK correctly parses the decimal dot (3.000000em), and all icons scale as expected.

By the way, launcher icons and indicators in wf-panel also suffer from this exact same issue under non-C locales, likely sharing the same floating-point formatting logic during CSS generation.

[mrfoggg]

Also, I have a few quick questions regarding the UI components and CSS styling in wf-locker:

1. Volume Widget: Why does the volume widget render two separate icon/slider containers? (Is one meant for Output/Sink and the other for Input/Source/Microphone?)
2. Weather Widget: Should the weather widget display an icon or weather condition text alongside the temperature? The JSON payload from the weather script contains icon, icon_name, conditions, etc., but only the temperature string (21°C) is currently visible on the screen.
3. Password Entry Styling: Is there a way (or specific GTK CSS node/class) to adjust the width, height, or padding of the password entry field? I couldn't find documentation regarding CSS nodes for wf-locker.

[trigg]

#536 should fix this, as it will enforce Locale when building css strings

[trigg]

In system locales that use a comma , instead of a dot . for decimals, wf-locker generates invalid GTK CSS strings like this:

Good catch! I hadn't remembered to set Locale before the CSS strings. My bad!

[trigg]

**Volume Widget:** Why does the volume widget render two separate icon/slider containers? (Is one meant for Output/Sink and the other for Input/Source/Microphone?)

It should have one for speaker and one for microphone, yes.

**Weather Widget:** Should the weather widget display an icon or weather condition text alongside the temperature? The JSON payload from the weather script contains `icon`, `icon_name`, `conditions`, etc., but only the temperature string (`21°C`) is currently visible on the screen.

My memory of this appears faulty. I was sure it included icons for the weather?

**Password Entry Styling:** Is there a way (or specific GTK CSS node/class) to adjust the width, height, or padding of the password entry field? I couldn't find documentation regarding CSS nodes for `wf-locker`.> 

You're right, I neglected to make widget trees for locker.
It would be

.password-entry {
...
}

you could also use .wf-locker .password-entry to be more specific or .wf-locker.eDP-1 .password-entry to only affect one output

https://docs.gtk.org/gtk4/class.Entry.html

It;s worth noting, if you aren't aware, the Entry has its own widget tree in CSS nodes here