You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
More Review Actions Triggers & Review objects
#1621
Requesting for some features. Github allows comments on individual commits, so I'd want to know if maintainers like these feature designs (not implemented yet):
The ability to trigger code review action on a pull request comment by users with write access, e.g @github-actions[bot] review or @github-actions review. I propose this as the allowed_association. Credits to hustcer here. Maybe we implement this in action.yml, seems like a small change to me.
The ability to trigger code review action and post generic code review (without line specific reviews and inline suggestions).
Same for here, only triggerable by users with write access,corresponding code-owners or collaborators and repository owners/admins.
One scope distinction may help. action.yml already accepts base_ref and head_sha for issue_comment-triggered runs and resolves PR context, while post-review-comments.js creates Review objects for inline batches and uses the sticky PR issue comment for findings without line locations. If the second proposal means a formal PR Review with a body but no inline comments, that is distinct from today’s summary comment.
For the trigger, would you prefer a documented author_association allowlist or a check of the commenter’s current repository permission? The first is a simple policy gate; the second more literally implements “write access” but needs the caller workflow to query current permission before invoking this composite action, since action.yml does not declare event triggers itself.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Requesting for some features. Github allows comments on individual commits, so I'd want to know if maintainers like these feature designs (not implemented yet):
@github-actions[bot] reviewor@github-actions review. I propose this as theallowed_association. Credits to hustcer here. Maybe we implement this inaction.yml, seems like a small change to me.Same for here, only triggerable by users with write access,corresponding code-owners or collaborators and repository owners/admins.
All reactions