refactor: remove redundant short IN list type check

Query planning converts the column and IN-list values to the same type
before this rule runs. Remove the extra type check while keeping the
requirement that list values are constants.

Update the test to convert Int32 list values to the Int64 column type
before checking both IN and NOT IN.

Author: geoffreyclaude

datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs

@@ -5172,11 +5172,12 @@ mod tests {
     }
 
     #[test]
-    fn simplify_short_inlist_mismatched_literals() {
-        // c3 is Int64; these Int32 literals have not been coerced.
-        let expr = in_list(col("c3"), vec![lit(1_i32), lit(2_i32)], false);
-        let expected = col("c3").eq(lit(1_i32)).or(col("c3").eq(lit(2_i32)));
-        assert_eq!(simplify(expr), expected);
+    fn simplify_short_inlist_coerced_literals() {
+        for negated in [false, true] {
+            let expr = in_list(col("c3"), vec![lit(1_i32), lit(2_i32)], negated);
+            let expected = in_list(col("c3"), vec![lit(1_i64), lit(2_i64)], negated);
+            assert_eq!(simplify(coerce(expr)), expected);
+        }
     }
 
     #[test]

datafusion/optimizer/src/simplify_expressions/inlist_simplifier.rs

@@ -48,10 +48,7 @@ impl<'a> ShortenInListSimplifier<'a> {
                 | DataType::Float32
                 | DataType::Float64
                 | DataType::FixedSizeBinary(1 | 2 | 4 | 8 | 16)
-        ) && list.iter().all(|expr| {
-            expr.as_literal()
-                .is_some_and(|value| value.data_type() == data_type)
-        })
+        ) && list.iter().all(|expr| expr.as_literal().is_some())
     }
 }