refactor(optimizer): rename pinned_for_known_consumers

The name said the opposite of the doc comment. The method is for a projection
that can stay in the plan for consumers that the caller can not see, so the
consumers are the unknown ones.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

Author: adriangb

datafusion/optimizer/src/extract_leaf_expressions.rs

@@ -92,7 +92,7 @@ fn pinned_for_merge<'a>(
     direct_columns: &IndexSet<Column>,
 ) -> PinnedDefinitions {
     let direct: Vec<Expr> = direct_columns.iter().cloned().map(Expr::Column).collect();
-    inliner.pinned_for_known_consumers(inlined, &direct, DuplicationCost::Free)
+    inliner.pinned_with_unknown_consumers(inlined, &direct, DuplicationCost::Free)
 }
 
 /// Extracts `MoveTowardsLeafNodes` sub-expressions from non-projection nodes

datafusion/optimizer/src/projection_inliner.rs

@@ -231,7 +231,7 @@ impl<'a> ProjectionInliner<'a> {
     /// the caller can not see. A copy of a forbidden definition would then
     /// be evaluated independently of the original, and change the query
     /// result.
-    pub(crate) fn pinned_for_known_consumers<'i, 'o>(
+    pub(crate) fn pinned_with_unknown_consumers<'i, 'o>(
         &self,
         inlined: impl IntoIterator<Item = &'i Expr>,
         others: impl IntoIterator<Item = &'o Expr>,
@@ -506,7 +506,7 @@ mod tests {
         // Without all the consumers, a single reference is pinned as well.
         assert!(
             !inliner
-                .pinned_for_known_consumers([&col("r")], no_others, max)
+                .pinned_with_unknown_consumers([&col("r")], no_others, max)
                 .is_empty()
         );
     }
@@ -525,7 +525,7 @@ mod tests {
             .is_not_null()
             .and(get_field_like(col("exp"), "x"));
         let other = col("cheap").gt(col("a"));
-        let pinned = inliner.pinned_for_known_consumers(
+        let pinned = inliner.pinned_with_unknown_consumers(
             [&twice, &other],
             no_others,
             DuplicationCost::Cheap,

datafusion/optimizer/src/push_down_filter.rs

@@ -1339,7 +1339,7 @@ fn rewrite_projection(
     //   optimizer instability: `ExtractLeafExpressions` undoes the push-down,
     //   which creates a loop that runs until the iteration limit is hit.
     let no_other_consumers: [&Expr; 0] = [];
-    let pinned = inliner.pinned_for_known_consumers(
+    let pinned = inliner.pinned_with_unknown_consumers(
         &predicates,
         no_other_consumers,
         DuplicationCost::Cheap,