Skip to content

Commit f02e137

Browse files
fix: remove unused unsupported() left over from the main rebase
Resolving the rebase conflict in decorrelate.rs kept this method alongside main's independent rename of the same method to stop_pull_up() (with a plain Transformed<LogicalPlan> return type). All call sites already use stop_pull_up(), so this was dead code.
1 parent 0e53674 commit f02e137

1 file changed

Lines changed: 2 additions & 9 deletions

File tree

‎datafusion/optimizer/src/decorrelate.rs‎

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ use datafusion_expr::utils::{
3636
collect_subquery_cols, conjunction, find_join_exprs, split_conjunction,
3737
};
3838
use datafusion_expr::{
39-
Aggregate, BinaryExpr, Cast, Distinct, EmptyRelation, Expr, ExprSchemable,
40-
FetchType, LogicalPlan, LogicalPlanBuilder, Operator, SkipType, expr, lit,
39+
Aggregate, BinaryExpr, Cast, Distinct, EmptyRelation, Expr, ExprSchemable, FetchType,
40+
LogicalPlan, LogicalPlanBuilder, Operator, SkipType, expr, lit,
4141
};
4242

4343
/// This struct rewrite the sub query plan by pull up the correlated
@@ -144,13 +144,6 @@ impl PullUpCorrelatedExpr {
144144
self
145145
}
146146

147-
/// Mark the plan as one whose correlated expressions cannot be pulled up
148-
/// and stop descending into it
149-
fn unsupported(&mut self, plan: LogicalPlan) -> Result<Transformed<LogicalPlan>> {
150-
self.can_pull_up = false;
151-
Ok(Transformed::new(plan, false, TreeNodeRecursion::Jump))
152-
}
153-
154147
/// Record the columns read above the subquery's `Aggregate`, computed
155148
/// from `subquery_plan` (the plan as it is before this rewrite runs).
156149
///

0 commit comments

Comments
 (0)