Skip to content

Commit fbbd6e1

Browse files
committed
review: add clarification on other join type's swap_inputs()
1 parent 175e0ee commit fbbd6e1

3 files changed

Lines changed: 25 additions & 0 deletions

File tree

‎datafusion/physical-plan/src/joins/cross_join.rs‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,12 @@ impl CrossJoinExec {
192192
///
193193
/// This is not a public API and is for internal use only; see [API policy] for details.
194194
///
195+
/// Direct use of this API in downstream projects is discouraged because
196+
/// correctness depends on strict preconditions. See the notes above for
197+
/// correct usage.
198+
///
199+
/// This API may change frequently as internal join optimizations evolve.
200+
///
195201
/// [API policy]: https://datafusion.apache.org/contributor-guide/api-health.html#internal-public-apis
196202
#[doc(hidden)]
197203
pub fn swap_inputs(&self) -> Result<Arc<dyn ExecutionPlan>> {

‎datafusion/physical-plan/src/joins/nested_loop_join.rs‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -481,6 +481,12 @@ impl NestedLoopJoinExec {
481481
///
482482
/// This is not a public API and is for internal use only; see [API policy] for details.
483483
///
484+
/// Direct use of this API in downstream projects is discouraged because
485+
/// correctness depends on strict preconditions. See the notes above for
486+
/// correct usage.
487+
///
488+
/// This API may change frequently as internal join optimizations evolve.
489+
///
484490
/// [API policy]: https://datafusion.apache.org/contributor-guide/api-health.html#internal-public-apis
485491
#[doc(hidden)]
486492
pub fn swap_inputs(&self) -> Result<Arc<dyn ExecutionPlan>> {

‎datafusion/physical-plan/src/joins/sort_merge_join/exec.rs‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -349,6 +349,19 @@ impl SortMergeJoinExec {
349349
/// This function should be called BEFORE inserting any repartitioning
350350
/// operators on the join's children. Check [`super::super::HashJoinExec::swap_inputs`]
351351
/// for more details.
352+
///
353+
/// # Public Only for Internal Use:
354+
///
355+
/// This is not a public API and is for internal use only; see [API policy] for details.
356+
///
357+
/// Direct use of this API in downstream projects is discouraged because
358+
/// correctness depends on strict preconditions. See the notes above for
359+
/// correct usage.
360+
///
361+
/// This API may change frequently as internal join optimizations evolve.
362+
///
363+
/// [API policy]: https://datafusion.apache.org/contributor-guide/api-health.html#internal-public-apis
364+
#[doc(hidden)]
352365
pub fn swap_inputs(&self) -> Result<Arc<dyn ExecutionPlan>> {
353366
let left = self.left();
354367
let right = self.right();

0 commit comments

Comments
 (0)