-
-
Notifications
You must be signed in to change notification settings - Fork 484
Expand file tree
/
Copy pathpasskey_test.go
More file actions
489 lines (408 loc) · 14.8 KB
/
Copy pathpasskey_test.go
File metadata and controls
489 lines (408 loc) · 14.8 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
package main
import (
"context"
"encoding/json"
"net/http"
"net/http/httptest"
"strings"
"testing"
"time"
"github.com/gorilla/mux"
"go.mau.fi/whatsmeow/types"
"go.mau.fi/whatsmeow/types/events"
)
// ===================== Test helpers =====================
// resetPasskeyMap clears the global pending passkey map and registers a
// cleanup so it is always cleared after each test finishes.
func resetPasskeyMap(t *testing.T) {
t.Helper()
pendingPasskeyMu.Lock()
pendingPasskeyRequests = make(map[string]*PendingPasskeyState)
pendingPasskeyMu.Unlock()
t.Cleanup(func() {
pendingPasskeyMu.Lock()
pendingPasskeyRequests = make(map[string]*PendingPasskeyState)
pendingPasskeyMu.Unlock()
})
}
// addTestUserForPasskey inserts a minimal user row and returns its ID.
func addTestUserForPasskey(t *testing.T, s *server, token string) string {
t.Helper()
userID := "test-user-" + token
_, err := s.db.Exec(
"INSERT INTO users (id, name, token) VALUES (?, ?, ?)",
userID, "Test User", token,
)
if err != nil {
t.Fatalf("insert test user: %v", err)
}
return userID
}
// injectUserInfo simulates the authalice middleware by placing a Values
// context value on the request.
func injectUserInfo(r *http.Request, userID string) *http.Request {
v := Values{map[string]string{
"Id": userID,
"Token": "test-token",
}}
return r.WithContext(context.WithValue(r.Context(), "userinfo", v))
}
// parseResponse unmarshals the recorder body and returns the map.
func parseResponse(t *testing.T, w *httptest.ResponseRecorder) map[string]interface{} {
t.Helper()
var resp map[string]interface{}
if err := json.Unmarshal(w.Body.Bytes(), &resp); err != nil {
t.Fatalf("invalid JSON response: %v\nbody: %s", err, w.Body.String())
}
return resp
}
// assertErrorBody checks that the response is a JSON-RPC-style error
// envelope (as returned by s.Respond with an error) and that the error
// message contains the expected substring.
func assertErrorBody(t *testing.T, w *httptest.ResponseRecorder, expectedStatus int, substr string) {
t.Helper()
if w.Code != expectedStatus {
t.Fatalf("expected status %d, got %d", expectedStatus, w.Code)
}
resp := parseResponse(t, w)
if resp["success"] != false {
t.Fatalf("expected success=false, got %v", resp["success"])
}
errMsg, _ := resp["error"].(string)
if !strings.Contains(errMsg, substr) {
t.Fatalf("expected error to contain %q, got %q", substr, errMsg)
}
}
// ===================== Memory / lifecycle tests =====================
func TestPendingPasskeyState_Lifecycle(t *testing.T) {
resetPasskeyMap(t)
t.Run("empty_map_returns_nil", func(t *testing.T) {
if pk := peekPendingPasskey("u1"); pk != nil {
t.Fatalf("peek expected nil, got %+v", pk)
}
if pk := getAndConsumePendingPasskey("u1"); pk != nil {
t.Fatalf("consume expected nil, got %+v", pk)
}
})
t.Run("peek_is_non_destructive", func(t *testing.T) {
state := &PendingPasskeyState{Request: &events.PairPasskeyRequest{}}
storePendingPasskey("u2", state)
if pk := peekPendingPasskey("u2"); pk == nil {
t.Fatal("first peek: expected state")
}
if pk := peekPendingPasskey("u2"); pk == nil {
t.Fatal("second peek: expected state again")
}
})
t.Run("consume_removes_state", func(t *testing.T) {
state := &PendingPasskeyState{Request: &events.PairPasskeyRequest{}}
storePendingPasskey("u3", state)
if pk := getAndConsumePendingPasskey("u3"); pk == nil {
t.Fatal("consume: expected state")
}
if pk := peekPendingPasskey("u3"); pk != nil {
t.Fatal("after consume: expected nil")
}
})
t.Run("double_consume_returns_nil", func(t *testing.T) {
state := &PendingPasskeyState{Request: &events.PairPasskeyRequest{}}
storePendingPasskey("u4", state)
_ = getAndConsumePendingPasskey("u4")
if pk := getAndConsumePendingPasskey("u4"); pk != nil {
t.Fatal("second consume should return nil")
}
})
}
func TestPendingPasskeyState_DeleteExplicitly(t *testing.T) {
resetPasskeyMap(t)
storePendingPasskey("d1", &PendingPasskeyState{Request: &events.PairPasskeyRequest{}})
if peekPendingPasskey("d1") == nil {
t.Fatal("expected state after store")
}
deletePendingPasskey("d1")
if peekPendingPasskey("d1") != nil {
t.Fatal("expected nil after explicit delete")
}
}
func TestPendingPasskeyState_IsolationBetweenUsers(t *testing.T) {
resetPasskeyMap(t)
storePendingPasskey("iso-a", &PendingPasskeyState{Request: &events.PairPasskeyRequest{}})
storePendingPasskey("iso-b", &PendingPasskeyState{Request: &events.PairPasskeyRequest{}})
getAndConsumePendingPasskey("iso-a")
if peekPendingPasskey("iso-a") != nil {
t.Fatal("user-a should be consumed")
}
if peekPendingPasskey("iso-b") == nil {
t.Fatal("user-b should still be present")
}
}
func TestPendingPasskeyState_Overwrite(t *testing.T) {
resetPasskeyMap(t)
state1 := &PendingPasskeyState{
Request: &events.PairPasskeyRequest{},
CreatedAt: time.Now().Add(-10 * time.Minute),
}
state2 := &PendingPasskeyState{
Request: &events.PairPasskeyRequest{},
CreatedAt: time.Now(),
}
storePendingPasskey("ow", state1)
storePendingPasskey("ow", state2) // overwrite
pk := peekPendingPasskey("ow")
if pk == nil {
t.Fatal("expected state after overwrite")
}
if pk.CreatedAt.Before(state2.CreatedAt.Add(-time.Second)) {
t.Fatal("second store should have overwritten the first")
}
}
func TestPendingPasskeyState_TTLExpiry(t *testing.T) {
resetPasskeyMap(t)
// Inject an old state directly (bypass store to set CreatedAt in the past)
pendingPasskeyMu.Lock()
pendingPasskeyRequests["old-user"] = &PendingPasskeyState{
Request: &events.PairPasskeyRequest{},
CreatedAt: time.Now().Add(-20 * time.Minute),
}
pendingPasskeyMu.Unlock()
// Simulate cleanup (mirrors the goroutine logic)
now := time.Now()
pendingPasskeyMu.Lock()
for uid, st := range pendingPasskeyRequests {
if now.Sub(st.CreatedAt) > passkeyStateTTL {
delete(pendingPasskeyRequests, uid)
}
}
pendingPasskeyMu.Unlock()
if peekPendingPasskey("old-user") != nil {
t.Fatal("expired state should have been cleaned up")
}
}
func TestPendingPasskeyState_FreshStateSurvivesCleanup(t *testing.T) {
resetPasskeyMap(t)
storePendingPasskey("fresh", &PendingPasskeyState{
Request: &events.PairPasskeyRequest{},
CreatedAt: time.Now(),
})
now := time.Now()
pendingPasskeyMu.Lock()
for uid, st := range pendingPasskeyRequests {
if now.Sub(st.CreatedAt) > passkeyStateTTL {
delete(pendingPasskeyRequests, uid)
}
}
pendingPasskeyMu.Unlock()
if peekPendingPasskey("fresh") == nil {
t.Fatal("fresh state should survive cleanup")
}
}
// getData extracts the "data" field from the standard s.Respond envelope.
func getData(t *testing.T, w *httptest.ResponseRecorder) map[string]interface{} {
t.Helper()
resp := parseResponse(t, w)
data, _ := resp["data"].(map[string]interface{})
if data == nil {
t.Fatalf("expected data field in response, got: %v", resp)
}
return data
}
// ===================== HTTP handler: GetPasskeyStatus =====================
func TestGetPasskeyStatus_NoPending(t *testing.T) {
resetPasskeyMap(t)
s := makeTestServer(t)
userID := addTestUserForPasskey(t, s, "ps-np")
req := httptest.NewRequest("GET", "/session/passkey-status", nil)
req = mux.SetURLVars(req, map[string]string{"id": userID})
req = injectUserInfo(req, userID)
w := httptest.NewRecorder()
s.GetPasskeyStatus()(w, req)
if w.Code != http.StatusOK {
t.Fatalf("expected 200, got %d", w.Code)
}
data := getData(t, w)
if data["passkeyPending"] != false {
t.Fatalf("expected passkeyPending=false, got %v", data["passkeyPending"])
}
if data["publicKey"] != nil {
t.Fatalf("expected publicKey=nil, got %v", data["publicKey"])
}
}
func TestGetPasskeyStatus_WithPending(t *testing.T) {
resetPasskeyMap(t)
s := makeTestServer(t)
userID := addTestUserForPasskey(t, s, "ps-wp")
fakePK := &types.WebAuthnPublicKey{RelyingPartID: "whatsapp.com", Timeout: 600000}
storePendingPasskey(userID, &PendingPasskeyState{
Request: &events.PairPasskeyRequest{PublicKey: fakePK},
CreatedAt: time.Now(),
})
req := httptest.NewRequest("GET", "/session/passkey-status", nil)
req = mux.SetURLVars(req, map[string]string{"id": userID})
req = injectUserInfo(req, userID)
w := httptest.NewRecorder()
s.GetPasskeyStatus()(w, req)
if w.Code != http.StatusOK {
t.Fatalf("expected 200, got %d", w.Code)
}
data := getData(t, w)
if data["passkeyPending"] != true {
t.Fatalf("expected passkeyPending=true, got %v", data["passkeyPending"])
}
if data["publicKey"] == nil {
t.Fatal("expected publicKey to be non-nil")
}
}
func TestGetPasskeyStatus_StateWithNilRequest(t *testing.T) {
resetPasskeyMap(t)
s := makeTestServer(t)
userID := addTestUserForPasskey(t, s, "ps-nr")
// Store a state where Request is nil
pendingPasskeyMu.Lock()
pendingPasskeyRequests[userID] = &PendingPasskeyState{
Request: nil,
CreatedAt: time.Now(),
}
pendingPasskeyMu.Unlock()
req := httptest.NewRequest("GET", "/session/passkey-status", nil)
req = mux.SetURLVars(req, map[string]string{"id": userID})
req = injectUserInfo(req, userID)
w := httptest.NewRecorder()
s.GetPasskeyStatus()(w, req)
data := getData(t, w)
// Request is nil → passkeyPending should be false
if data["passkeyPending"] != false {
t.Fatalf("expected passkeyPending=false when Request=nil, got %v", data["passkeyPending"])
}
}
// ===================== HTTP handler: GetQR =====================
// TestGetQR_NoSession_ReturnsNoSession verifies that GetQR returns a 500
// with "no session" when the clientManager has no client for this user.
// This is the realistic path since we cannot spin up a real whatsmeow
// client in a unit test.
func TestGetQR_NoSession_ReturnsNoSession(t *testing.T) {
resetPasskeyMap(t)
s := makeTestServer(t)
userID := addTestUserForPasskey(t, s, "qr-ns")
req := httptest.NewRequest("GET", "/session/qr", nil)
req = mux.SetURLVars(req, map[string]string{"id": userID})
req = injectUserInfo(req, userID)
w := httptest.NewRecorder()
s.GetQR()(w, req)
// GetQR checks clientManager first → no client = "no session" error
assertErrorBody(t, w, http.StatusInternalServerError, "no session")
}
// TestGetQR_NoSession_DoesNotLeakPasskey verifies that even when a
// passkey is pending, the "no session" check happens first. The passkey
// state should remain unconsumed.
func TestGetQR_NoSession_DoesNotLeakPasskey(t *testing.T) {
resetPasskeyMap(t)
s := makeTestServer(t)
userID := addTestUserForPasskey(t, s, "qr-leak")
fakePK := &types.WebAuthnPublicKey{RelyingPartID: "whatsapp.com"}
storePendingPasskey(userID, &PendingPasskeyState{
Request: &events.PairPasskeyRequest{PublicKey: fakePK},
CreatedAt: time.Now(),
})
req := httptest.NewRequest("GET", "/session/qr", nil)
req = mux.SetURLVars(req, map[string]string{"id": userID})
req = injectUserInfo(req, userID)
w := httptest.NewRecorder()
s.GetQR()(w, req)
// Should fail with "no session"
if w.Code != http.StatusInternalServerError {
t.Fatalf("expected 500, got %d", w.Code)
}
// Passkey state should NOT have been consumed
if pk := peekPendingPasskey(userID); pk == nil {
t.Fatal("passkey state should still exist after GetQR 'no session' error")
}
}
// ===================== HTTP handler: PasskeyResponse =====================
func TestPasskeyResponse_NoPendingReturns400(t *testing.T) {
resetPasskeyMap(t)
s := makeTestServer(t)
userID := addTestUserForPasskey(t, s, "pr-400")
body := `{"response":{"id":"x","rawId":"x","type":"public-key","response":{"clientDataJSON":"x","authenticatorData":"x","signature":"x","userHandle":null}}}`
req := httptest.NewRequest("POST", "/session/passkey-response", strings.NewReader(body))
req = mux.SetURLVars(req, map[string]string{"id": userID})
req = injectUserInfo(req, userID)
w := httptest.NewRecorder()
s.PasskeyResponse()(w, req)
assertErrorBody(t, w, http.StatusBadRequest, "no pending passkey")
}
func TestPasskeyResponse_InvalidJSON_Returns400AndRestoresState(t *testing.T) {
resetPasskeyMap(t)
s := makeTestServer(t)
userID := addTestUserForPasskey(t, s, "pr-badjson")
fakePK := &types.WebAuthnPublicKey{RelyingPartID: "whatsapp.com"}
storePendingPasskey(userID, &PendingPasskeyState{
Request: &events.PairPasskeyRequest{PublicKey: fakePK},
CreatedAt: time.Now(),
})
req := httptest.NewRequest("POST", "/session/passkey-response", strings.NewReader("NOT_JSON"))
req = mux.SetURLVars(req, map[string]string{"id": userID})
req = injectUserInfo(req, userID)
w := httptest.NewRecorder()
s.PasskeyResponse()(w, req)
assertErrorBody(t, w, http.StatusBadRequest, "could not decode")
// State should be restored so the user can retry
if pk := peekPendingPasskey(userID); pk == nil {
t.Fatal("state should be restored after decode error")
}
}
func TestPasskeyResponse_MissingResponseField_Returns400AndRestoresState(t *testing.T) {
resetPasskeyMap(t)
s := makeTestServer(t)
userID := addTestUserForPasskey(t, s, "pr-noresp")
fakePK := &types.WebAuthnPublicKey{RelyingPartID: "whatsapp.com"}
storePendingPasskey(userID, &PendingPasskeyState{
Request: &events.PairPasskeyRequest{PublicKey: fakePK},
CreatedAt: time.Now(),
})
// Valid JSON but missing the "response" field
req := httptest.NewRequest("POST", "/session/passkey-response", strings.NewReader("{}"))
req = mux.SetURLVars(req, map[string]string{"id": userID})
req = injectUserInfo(req, userID)
w := httptest.NewRecorder()
s.PasskeyResponse()(w, req)
assertErrorBody(t, w, http.StatusBadRequest, "missing response")
// State should be restored
if pk := peekPendingPasskey(userID); pk == nil {
t.Fatal("state should be restored after missing response field")
}
}
// ===================== HTTP handler: PasskeyConfirm =====================
func TestPasskeyConfirm_NoPendingReturns400(t *testing.T) {
resetPasskeyMap(t)
s := makeTestServer(t)
userID := addTestUserForPasskey(t, s, "pc-400")
req := httptest.NewRequest("POST", "/session/passkey-confirm", nil)
req = mux.SetURLVars(req, map[string]string{"id": userID})
req = injectUserInfo(req, userID)
w := httptest.NewRecorder()
s.PasskeyConfirm()(w, req)
assertErrorBody(t, w, http.StatusBadRequest, "no pending passkey")
}
func TestPasskeyConfirm_StateWithNilClientReturns400(t *testing.T) {
resetPasskeyMap(t)
s := makeTestServer(t)
userID := addTestUserForPasskey(t, s, "pc-nil")
// State exists but Client is nil
pendingPasskeyMu.Lock()
pendingPasskeyRequests[userID] = &PendingPasskeyState{
Request: &events.PairPasskeyRequest{},
Client: nil,
CreatedAt: time.Now(),
}
pendingPasskeyMu.Unlock()
req := httptest.NewRequest("POST", "/session/passkey-confirm", nil)
req = mux.SetURLVars(req, map[string]string{"id": userID})
req = injectUserInfo(req, userID)
w := httptest.NewRecorder()
s.PasskeyConfirm()(w, req)
assertErrorBody(t, w, http.StatusBadRequest, "no pending passkey")
// State should still exist (peek was used, not consume)
if pk := peekPendingPasskey(userID); pk == nil {
t.Fatal("state should still exist after nil-client check")
}
}