Skip to content

Cell renderer refactoring #77

Description

@bennyboer

Most cell renderers, especially the newer ones like the Combobox cell renderer always have the same patterns.

  • Introduce AbstractCanvasCellRenderer class that already supports common actions
  • Every cell should have an additional options field that is currently in most cell renderer values included
  • Remove editable fields from cell renderer options
    • Instead: introduce cell renderers solely for editing like a TextEditorCellRenderer that will render a text field.
    • A global event listener is to be provided at the TableEngine options where you can defined what happens when a cell is double clicked for example
    • When a cell is double clicked the users of the library are able to exchange the cell renderer for example for a double-clicked text cell, to the text editor cell renderer and set the editor options to replace the editor again with the previous renderer when done
  • Update cell renderer documentation

Refactoring checklist

  • Button
  • Checkbox
  • Combobox
  • DOM
  • Row/column header
  • Image
  • Loading
  • Progress
  • Rating
  • Text

To-Do

  • Global event listeners to for example exchange cell renderer on double click
  • Refactoring text cell renderer to not include an editor - instead create another cell renderer that is to be used instead
  • Remove editable field from text cell renderer
  • Update cell renderer documentation

Metadata

Metadata

Assignees

Labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions