-
-
Notifications
You must be signed in to change notification settings - Fork 66
[BUG] Validation study may use unconverged parameters #114
Copy link
Copy link
Open
Labels
bugSomething isn't workingSomething isn't workingmaintenanceImprovements or additions to documentation, testing, robustness, or toolingImprovements or additions to documentation, testing, robustness, or toolingquestionFurther information is neededFurther information is needed
Milestone
Description
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingmaintenanceImprovements or additions to documentation, testing, robustness, or toolingImprovements or additions to documentation, testing, robustness, or toolingquestionFurther information is neededFurther information is needed
Bug Description
The validation study may be running with mesh and time step parameters that have not been verified as converged. This could undermine the validity of comparisons against experimental data.
Location(s):
validation/validation_study.pyExpected Behavior
The convergence analysis should be redone and the simulation parameters updated if they are found to be unconverged.
Additional Context
This issue is referenced by a
TODOcomment at the top of the validation study.