fix: Ctrl+I leaves focus in an open command palette

Author: ThomasK33

src/browser/features/ChatInput/index.tsx

@@ -1359,7 +1359,10 @@ const ChatInputInner: React.FC<ChatInputProps> = (props) => {
         return;
       }
       event.preventDefault();
-      if (!isDialogOpen()) focusMessageInput();
+      // isDialogOpen() misses the command palette (cmdk); focus must not move behind it.
+      const inCommandPalette =
+        event.target instanceof Element && event.target.closest("[cmdk-root]") != null;
+      if (!isDialogOpen() && !inCommandPalette) focusMessageInput();
     };
     window.addEventListener("keydown", handleFocusChat, { capture: true });
     return () => window.removeEventListener("keydown", handleFocusChat, { capture: true });

tests/bugbash/repros/focusAndLabels.e2e.ts

@@ -22,6 +22,13 @@ test(
 
     await browser.keyboard.press("Control+i");
     await expect(composer).toBeFocused();
+
+    // With the command palette open, Ctrl+I leaves focus in the palette.
+    await browser.keyboard.press("Control+Shift+P");
+    const palette = screen.getByRole("combobox", "Command palette");
+    await expect(palette).toBeFocused();
+    await browser.keyboard.press("Control+i");
+    await expect(palette).toBeFocused();
   }
 );