Merge pull request #2675 from contentstack/fix/logger-circular-object-parsing

fixed circular object parsing bug

Author: shafeeqd959

.talismanrc

@@ -1,4 +1,4 @@
 fileignoreconfig:
   - filename: pnpm-lock.yaml
-    checksum: 763c12b0555cbd63ca4015664e08de315f0e675125a34de2d9c8d1a73a3723e8
+    checksum: 3894686f64c8bf322cb7917c79193268344c68037ef1a41808f1509fc227087d
 version: '1.0'

packages/contentstack-utilities/src/logger/logger.ts

@@ -65,7 +65,7 @@ export default class Logger {
             winston.format.printf((info) => {
               // Apply minimal redaction for files (debugging info preserved)
               const redactedInfo = this.redact(info, false);
-              return JSON.stringify(redactedInfo);
+              return this.safeStringify(redactedInfo);
             }),
           ),
         }),
@@ -117,6 +117,26 @@ export default class Logger {
     }
   }
 
+  /**
+   * Stringifies a log entry without throwing on circular references.
+   * `redact()` can fall back to the original (still-circular) object when
+   * cloning fails, so this must never assume the input is cycle-free.
+   */
+  private safeStringify(value: any): string {
+    const seen = new WeakSet();
+    try {
+      return JSON.stringify(value, (_key, val) => {
+        if (typeof val === 'object' && val !== null) {
+          if (seen.has(val)) return '[Circular]';
+          seen.add(val);
+        }
+        return val;
+      });
+    } catch {
+      return JSON.stringify({ level: value?.level, message: value?.message ?? '[Unserializable log entry]' });
+    }
+  }
+
   private shouldLog(level: LogType, target: 'console' | 'file'): boolean {
     // If console logging is disabled, don't log to console
     if (target === 'console' && this.config.consoleLoggingEnabled === false) {
@@ -186,9 +206,12 @@ export default class Logger {
       this.loggers.error.error(logPayload);
     }
 
-    // For console, use debug level if hidden, otherwise error level
+    // For console, use debug level if hidden, otherwise error level. Each level's
+    // winston logger instance bundles both the file and console transports, so only
+    // write again here when the target differs from the one already written above —
+    // otherwise this would duplicate both the console line and the file entry.
     const consoleLevel: LogType = params.hidden ? 'debug' : 'error';
-    if (this.shouldLog(consoleLevel, 'console')) {
+    if (consoleLevel !== 'error' && this.shouldLog(consoleLevel, 'console')) {
       this.loggers[consoleLevel].error(logPayload);
     }
   }

packages/contentstack/package.json

@@ -162,4 +162,4 @@
     }
   },
   "repository": "https://github.com/contentstack/cli"
-}
+}