refactor(projects): move CreateRequest to types.ts and keep the create parts' constants private

Follow-up to the ProjectCreator split, from the review of it:

- ProjectSource and EnvironmentBuilder imported the CreateRequest type
  from project.create.ts, which imports both of them, so the
  orchestrator and its collaborators depended on each other. Type-only
  today, but one value import away from a real load-order cycle.
  CreateRequest now lives in projects/types.ts with the other request
  shapes, and only the command and the tests import project.create.ts.
- The split carried export along with six constants that nothing
  outside their own file uses - NO_DEPLOYMENT_STATUS and
  FIRST_LOOKUP_ATTEMPTS in project.follow.ts, GIT_NAMESPACE_PAGE_SIZE in
  project.source.ts, DEFAULT_ENVIRONMENT_NAME,
  DUPLICATE_PROJECT_NAME_CODE and PROJECT_RENAME_ATTEMPTS in
  project.create.ts - which made each collaborator look like it offered
  more than its one class. They are module-private.
- AGENTS.md said ProjectCreator applies the --server-cmd framework check
  once the framework is known; EnvironmentBuilder does.

No behaviour change; ProjectCreator keeps its timing field, which the
command test reads to check the real clock is passed through.

#claude_code#
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: SakshiKoli-CS

.talismanrc

@@ -12,7 +12,7 @@ fileignoreconfig:
 - filename: src/transport/auth-strategy.test.ts
   checksum: a4f3e3ea7db10dbf82abbac0207d2231ee740916f476fcda836a2268505295ef
 - filename: src/projects/types.ts
-  checksum: 563a1f339c7b1ba1a366e8cac087a52805af21d46f07e4078716358ed99270f5
+  checksum: 6139553ef747421f5b7ee701f82dcdb7071f0cb614c977967a2cb3974495e43c
 - filename: src/projects/projects.api.ts
   checksum: 29d53afdfa763ea00f8922e7ff48459a88d6acccc865c14831cbc6070c657dda
 - filename: src/core/service-context.test.ts

AGENTS.md

@@ -619,7 +619,8 @@ The framework gate is the declarative rule `onlyWithValueOf('server-cmd', 'frame
 exported as `serverCommandFrameworkGate` and declared in `static rules` with `gitOnlyFlagRules`
 (`--branch`, `--namespace`, `--repo` only with `--type GitHub`). A rule judges its gate only when the
 user supplied the gate: with `--framework` on argv, a bad pairing costs exit 2 and nothing on the
-wire. When the framework is prompted or detected later, `ProjectCreator` applies the same check
+wire. When the framework is prompted or detected later, `EnvironmentBuilder` in
+`src/projects/project.environment.ts` applies the same check
 (`requireValueOf`) once it knows the framework, still before `POST /projects`.
 
 **Without a terminal, create uses what it can infer.** The framework is the detected one (exit 2 naming

src/projects/project.create.test.ts

@@ -14,7 +14,7 @@ import type { ApiErrorEntry } from '../transport/errors';
 import { LaunchApiError } from '../transport/errors';
 import { GitConnectionMissingError } from '../git/git.errors';
 import type { ApiSurface } from '../resources';
-import type { CreateRequest } from './project.create';
+import type { CreateRequest } from './types';
 import { ProjectCreator } from './project.create';
 import { SITE_OPEN_DELAY_MS } from './project.follow';
 import { UPLOAD_PROGRESS_LABEL } from './project.source';

src/projects/project.create.ts

@@ -7,9 +7,7 @@ import { askText } from '../core/prompt';
 import type { ServiceContext } from '../core/service-context';
 import { messageOf } from '../core/values';
 import type { WatchTiming } from '../deployments/deployment.watcher';
-import type { ResponseMode, ToggleValue } from '../environments/environment.inputs';
 import { ENVIRONMENT_NAME_MAX_LENGTH } from '../environments/environment.inputs';
-import type { FrameworkPreset } from '../environments/frameworks';
 import { repositoryLabel } from '../git/git.presenter';
 import { repositorySearchTerm } from '../git/git.prompt';
 import type { LocalGitHubRepository } from '../git/local-repository';
@@ -37,30 +35,12 @@ import {
   renameRetryLimitLine,
 } from './project.presenter';
 import { ProjectSource } from './project.source';
-import type { CreateProjectInput, IdentifiedProject } from './types';
+import type { CreateProjectInput, CreateRequest, IdentifiedProject } from './types';
 import { PROJECT_NAME_MAX_LENGTH } from './types';
 
-export const DEFAULT_ENVIRONMENT_NAME = 'Default';
-export const DUPLICATE_PROJECT_NAME_CODE = 'launch.PROJECT.DUPLICATE_NAME';
-export const PROJECT_RENAME_ATTEMPTS = 3;
-
-export interface CreateRequest {
-  org: string;
-  dataDir: string;
-  configPath: string;
-  type?: ProjectTypeChoice;
-  name?: string;
-  description?: string;
-  envName?: string;
-  branch?: string;
-  framework?: FrameworkPreset;
-  buildCmd?: string;
-  outputDir?: string;
-  serverCmd?: string;
-  resMode?: ResponseMode;
-  autoDeploy?: ToggleValue;
-  csAuth?: ToggleValue;
-}
+const DEFAULT_ENVIRONMENT_NAME = 'Default';
+const DUPLICATE_PROJECT_NAME_CODE = 'launch.PROJECT.DUPLICATE_NAME';
+const PROJECT_RENAME_ATTEMPTS = 3;
 
 function shownPath(path: string): string {
   const absolute = resolve(path);

src/projects/project.environment.ts

@@ -12,10 +12,9 @@ import {
   SERVER_COMMAND_FRAMEWORKS,
 } from '../environments/frameworks';
 import type { CreateEnvironmentInput } from '../environments/types';
-import type { CreateRequest } from './project.create';
 import { CREATE_PROMPT_REMEDIES } from './project.inputs';
 import type { SourceSelection } from './project.source';
-import type { DetectedFramework } from './types';
+import type { CreateRequest, DetectedFramework } from './types';
 
 function emptyEnvironmentVariables(): [] {
   return [];

src/projects/project.follow.ts

@@ -11,8 +11,8 @@ import type { Environment } from '../environments/types';
 import { deploymentFailureMessage, deploymentUrlLine } from './project.presenter';
 import type { IdentifiedProject } from './types';
 
-export const NO_DEPLOYMENT_STATUS = 'NONE';
-export const FIRST_LOOKUP_ATTEMPTS = 3;
+const NO_DEPLOYMENT_STATUS = 'NONE';
+const FIRST_LOOKUP_ATTEMPTS = 3;
 export const SITE_OPEN_DELAY_MS = 6000;
 
 interface Survivors {

src/projects/project.source.ts

@@ -14,14 +14,13 @@ import type { GitNamespacesPage, GitRepository } from '../git/types';
 import { GIT_PROVIDER_GITHUB } from '../git/types';
 import { LaunchApiError } from '../transport/errors';
 import { archiveDirectory } from './project.archive';
-import type { CreateRequest } from './project.create';
 import { needInput } from './project.inputs';
 import { PREPARING_ARCHIVE } from './project.presenter';
 import { refuseArchiveOutsideLimits, uploadArchive } from './project.upload';
-import type { DetectedFramework, SignedUploadUrl } from './types';
+import type { CreateRequest, DetectedFramework, SignedUploadUrl } from './types';
 
 export const UPLOAD_PROGRESS_LABEL = 'Uploading project.zip';
-export const GIT_NAMESPACE_PAGE_SIZE = 100;
+const GIT_NAMESPACE_PAGE_SIZE = 100;
 
 export interface SourceSelection {
   detected: DetectedFramework;

src/projects/types.ts

@@ -1,5 +1,8 @@
 import type { Pagination } from '../core/render';
+import type { ResponseMode, ToggleValue } from '../environments/environment.inputs';
+import type { FrameworkPreset } from '../environments/frameworks';
 import type { CreateEnvironmentInput } from '../environments/types';
+import type { ProjectTypeChoice } from './project.inputs';
 
 export type { Pagination };
 
@@ -96,3 +99,21 @@ export interface ProjectsPage {
   pagination: Pagination;
   projects: Project[];
 }
+
+export interface CreateRequest {
+  org: string;
+  dataDir: string;
+  configPath: string;
+  type?: ProjectTypeChoice;
+  name?: string;
+  description?: string;
+  envName?: string;
+  branch?: string;
+  framework?: FrameworkPreset;
+  buildCmd?: string;
+  outputDir?: string;
+  serverCmd?: string;
+  resMode?: ResponseMode;
+  autoDeploy?: ToggleValue;
+  csAuth?: ToggleValue;
+}