dependency-check.bat does not use JAVA_HOME

[OrangeDog]

Precondition

• I checked the issues list for existing open or closed reports of the same problem.

Describe the bug
If java is not on the PATH then the CLI fails on Windows, even though JAVA_HOME is correctly configured.

Version of dependency-check used
The problem occurs using version 12.2.2 of the cli

Log file

java : The term 'java' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
At line:1 char:1
+ java
+ ~~~~
    + CategoryInfo          : ObjectNotFound: (java:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

Expected behavior
The script should check, and indeed prefer, JAVA_HOME to find the java executable.

Workaround
Adjust either PATH or JAVACMD variables before calling the script.

[chadlwilson]

The batch script used was generated by a now abandoned appassembler plugin project, so the approach probably needs replacing. The template was overridden to fix "paths with spaces" issues already as a result. I guess it never supported JAVA_HOME on Windows.

You might want to consider using something like mise as a cross-platform version manager that will automatically set PATH and JAVA_HOME correctly and dynamically (or docker image of course).

[OrangeDog]

I have set JAVACMD to %JAVA_HOME%\bin\java, but it's generally expected that java-based tools use JAVA_HOME.

[chadlwilson]

Or have binaries on the PATH, actually - like every tool in every ecosystem on every operating system.