tab to indent (e.g. for loops) apparently not working

[michaeldesu]

Thanks for making this. It will be useful for people like me learning imba.

imba-shell version: x.x.x

Imba Shell v0.5.1

Details

I was testing the for n in numbers style as shown in the gif, but after entering that line of code and pressing enter, the cursor was not positioned on the next line at the expected indented position, nor could I tab to the expected position (the cursor was at the start of the next line). Using the .editor mode did not improve the situation.

Expected Behavior

Either tab to the indented position, or allow tab key to move the cursor for the above case (i.e. for loop)

Actual Behavior

Cursor was at the start of the next line

Possible Fix

Additional Info

Your Environment

• Windows 10, node v18.17.1, imba 2.0.0-alpha.231

[donaldp]

Hey @michaeldesu

Thanks for trying this out. Just a quick one while I investigate the issue, are you using Shift+Tab to indent to the right place as mentioned here: https://github.com/donaldp/imba-shell#indentation?

[michaeldesu]

thanks @donaldp for your quick reply. No I'm just using the regular tab keypress. Pressing Shift-Tab is not making any difference / improvement for me either.

[donaldp]

It might be Windows related as I'm unable to replicate the issue on Mac and Linux. I'll spin up a Windows machine and test on it

[michaeldesu]

@donaldp I could confirm it works ok on my old Macbook Air (using .editor & shift-tab), so as you say, it seems to be Windows-specific.

I guess it may be early days for the shell, but personally I think it would be ideal if it would be possible to simply use Tab (as Shift-Tab is a bit awkward to use and not usual), and while it's ok, perhaps not having to go into .editor mode may be preferable. Perhaps it might be better to avoid Ctrl-D to exit the editor and execute but letting the user press an additional carriage-return to do that instead?