What
We have the /examples directory for demonstration to the user.
Right now a reviewer has to keep in mind to make sure the example is working which could cause breaking changes to be merged.
We should make it so that we can test the example is working automatically with bazel test to prevent errors.
Acceptance Criteria (DoD)
bazel test //examples/... shall test that the demo is working correctly.
How
- A docker image should be defined in the bazel
- We could reuse the base of the image from our tests maybe?
|
oci_image( |
|
name = "image", |
|
base = "@debian-test-runtime", |
|
) |
- We should also see how much of the code could be shared with
/tests/integration/smoke (not sure as the test has gtest APIs so we shall decide)
- The scripts that copies the binaries into the correct location shall be replaced with an
oci_images( ... tars = [ demo_files ]) even if we choose to use the test image as a base this is possible.
- Add the `oci_images(... entrypoint = lcm_binary_path )
What
We have the
/examplesdirectory for demonstration to the user.Right now a reviewer has to keep in mind to make sure the example is working which could cause breaking changes to be merged.
We should make it so that we can test the example is working automatically with
bazel testto prevent errors.Acceptance Criteria (DoD)
bazel test //examples/...shall test that the demo is working correctly.How
lifecycle/tests/utils/environments/x86_64-linux/BUILD
Lines 15 to 18 in 1d257e1
/tests/integration/smoke(not sure as the test has gtest APIs so we shall decide)oci_images( ... tars = [ demo_files ])even if we choose to use the test image as a base this is possible.