Order: traderID

[vanodevium]

First of all, thanks for your great work!

---

Created orders have no indication of who created them. It follows that I, as a trader, can buy from myself or sell to myself. It seems to me that this is not entirely logical.

I think it would be great to add a Trader ID for each order and just skip orders with the same Trader ID in the matching process.

[fasenderos]

Hi @vanodevium thank you for your interest in this project.

Created orders have no indication of who created them. It follows that I, as a trader, can buy from myself or sell to myself. It seems to me that this is not entirely logical.

It seems wrong at first, but I'm not entirely sure this actually did not happens on real exchanges. Did you have any technical documentations about that? I think these are choices to make at application level. The maching engine is just part of an exchange, all the logic around you needs to work out.

[vanodevium]

You're right. I already investigate logic of different matching engines and they allow to trade himself.

Thanks!

[fasenderos]

implemented in #596