De-duplicate results in Snacks.picker.lsp_references

[impankratov]

Hi there 👋

I've basically have the same problem as described in this issue: #1807

When using Snacks.picker.lsp_references with multiple active LSP servers, picker combines multiple requests into single result.

And quite often there are duplicated results - each from different LSP.

I wanted to somehow filter the results to remove duplicates. Tried this using custom filter function (picker.filter.filter configuration option), but because there are multiple requests processed by each LSP server this results in multiple execution of filter function, each execution with results from specific LSP. Because of that there's no de-duplication possible.

Example:
LSP-a results:

• file1
• file2
• file3
  (filter function execution)

LSP-b results:

• file1

(filter function execution)

Picker opens with results combined:

• file1
• file2
• file3
• file1 (duplicated result which I want to remove)

Is there any way to execute some other callback when picker opens with all of the items? I've also tried using picker.on_show callback, but items change there does nothing (or most probably I'm doing it wrong)

on_show code example:

on_show = function(picker)
  picker.finder.items = remove_similar_items_efficient(picker.finder.items)
  picker.list.items = remove_similar_items_efficient(picker.list.items)

  picker:refresh()
  picker:update({ force = true })
end,

Would appreciate any help, thanks!

[drowning-cat]

Should be doable, not tested properly:

---@module 'snacsk'

---@class snacks.Picker
---@field seen table<string, boolean?>

return {
  "folke/snacks.nvim",
  priority = 1000,
  lazy = false,
  ---@type snacks.Config
  opts = {
    picker = {
      sources = {
        lsp_references = {
          finder = function(opts, ctx)
            ctx.picker.seen = {}
            return require("snacks.picker.source.lsp").references(opts, ctx)
          end,
          transform = function(item, ctx)
            -- vim.print(item)
            local seen = ctx.picker.seen
            local id = vim.inspect({ item.text }) -- NOTE: Change
            if seen[id] then
              return false
            end
            seen[id] = true
            return true
          end,
        },
      },
    },
  },
}

[impankratov]

Would've never guess it can be done this way

Thank you!

[Danthewaann]

I had to change local id = vim.inspect({ item.text }) in the above example to local id = vim.inspect({ item.file, item.pos, item.end_pos }) as item.text alone isn't unique enough. Entries that looked the same but where actually located on different lines where getting filtered out.