Dispatch role check maps retro and prioritize to fullsend meta-role, bypassing per-stage disable in org config

[fullsend-ai-retro]

What happened

The konflux-ci org config.yaml (in konflux-ci/.fullsend) has the retro role commented out in defaults.roles with a note: 'Retro agent is awesome, but it currently has a bug where it fails to post a comment back on the PR that triggered it. Let's re-enable after this is fixed: #1076'. Issue #1076 was closed (the bug was fixed), but the config was never updated to re-enable retro. Despite being commented out, retro continues to dispatch on every merged PR. The dispatch.yml 'Check role is enabled' step maps the retro stage to the 'fullsend' meta-role: retro|prioritize) STAGE_ROLE="fullsend". Since 'fullsend' is in the roles list, the check always passes regardless of whether 'retro' is listed.

What could go better

The config suggests the org intended to disable retro, but the role mapping makes this impossible without also disabling prioritize and the fullsend meta-role itself. This is a config/implementation mismatch: the config file appears to offer per-stage control via the roles list, but the dispatch implementation groups retro and prioritize under a single meta-role. Anyone reading the config would incorrectly believe retro is disabled. If the org's intent was to keep retro disabled until #1076 was fixed, retro has been running unintentionally since that fix landed. If retro was re-enabled intentionally (without updating the config), then the stale comment is misleading. Either way there is a discrepancy. Confidence is high — the dispatch.yml role mapping logic is unambiguous.

Proposed change

Two changes are needed: (1) In dispatch.yml, check stages against their own names rather than mapping to a meta-role. Change the role check so that 'retro' checks for 'retro' in the roles list and 'prioritize' checks for 'prioritize'. If a meta-role like 'fullsend' should also enable them, add logic like: stage is enabled if its own name OR 'fullsend' is in the roles list. This allows per-stage disable while preserving the convenience of the meta-role. (2) In the konflux-ci org config.yaml, either uncomment '- retro' to explicitly re-enable it (since #1076 is fixed), or remove the stale comment and confirm it should remain disabled. The current state is ambiguous.

Validation criteria

(1) After updating dispatch.yml: commenting out 'retro' in defaults.roles actually prevents retro dispatch, even when 'fullsend' is present. (2) Commenting out 'prioritize' independently prevents prioritize dispatch without affecting retro. (3) Adding 'fullsend' to roles still enables both retro and prioritize as a convenience shortcut. (4) The konflux-ci org config accurately reflects the org's current intent for retro dispatch.

---

Generated by retro agent from konflux-ci/release-service#1797

[fullsend-ai-triage]

Meeting update — 2026-07-28

Relevant to this issue: The meeting authorized re-enabling the retro agent in the Konflux CI environment, directly affecting how retro dispatches are controlled via org config. Previous issues that led to retro's disablement have been resolved, and the team aligned on proceeding with re-enablement.

• Decision: Retro agent is authorized for re-enablement in Konflux CI following resolution of previous blocking bugs
• Retro agents had been temporarily disabled to stabilize performance across repositories; this re-enablement is scoped to Konflux CI initially
• Action items include inspecting the Konflux CI configuration file for current retro agent status and confirming functionality post-enablement
• Status updates will be posted to the original discussion thread once re-enabled

Related PRs: PR #5513 adds flapping detection to retro analysis, improving retro reliability

Next steps: Verify Konflux CI configuration, re-activate the retro agent, and confirm operational status

Meeting notes

[fullsend-ai-prioritize]

RICE Priority Score: 1.8

Score breakdown

Dimension	Score	Reasoning
Reach	1.5	This is a platform-level bug in dispatch.yml that affects all orgs using fullsend. Any org that attempts to independently disable the retro or prioritize stage via their config roles list will find the setting silently ignored. The konflux-ci org is the known affected case, but any org relying on per-stage role control is impacted.
Impact	1.5	The config file promises per-stage control that doesn't actually work — operators believe retro is disabled when it is still running on every merged PR. This is a significant mismatch between documented config behavior and actual dispatch logic, causing unintended agent execution and misleading configuration. A workaround exists (remove the fullsend meta-role entirely) but defeats its purpose.
Confidence	0.8	High confidence — the issue is exceptionally well-described with unambiguous root cause analysis. The dispatch.yml role mapping logic is clearly identified, the validation criteria are specific and testable, and a meeting comment confirms the team's intent. The only minor gap is whether other orgs have been affected, but the platform-level nature of the bug is clear.
Effort	1	Medium effort — requires changing the role-check logic in dispatch.yml to check stage names individually with fallback to the fullsend meta-role, plus updating the konflux-ci org config. The change is well-scoped to two files with clear validation criteria, but touches shared dispatch infrastructure that needs careful testing to avoid breaking stage enablement for other orgs.

Formula: (1.5 x 1.5 x 0.8) / 1 = 1.8

[waynesun09]

/fs-triage

[fullsend-ai-triage]

🤖 Finished Triage · ✅ Success · Started 1:24 PM UTC · Completed 1:28 PM UTC

Commit: 122e680 · View workflow run →