What happened
During review of PR #6147, the author (sonupreetam) noted that qodo-code-review's Go convention pack includes testify rules TC-001 and TC-002 that reference testing conventions the project does not follow. In a comment on 2026-08-13, the author raised this as a side concern, and qodo-code-review[bot] confirmed the convention pack was stale and agreed an issue should be filed. No issue was filed at that time. On this particular PR, qodo's 2 actual findings were both valid (secret leakage, reasoning token loss), but the stale convention pack creates a standing false-positive risk for future Go test PRs.
What could go better
The qodo Go convention pack encodes testing rules (TC-001, TC-002) that assume the project uses testify assertions and test suites. The project uses a different testing approach, so these rules can produce false-positive findings on new test code — flagging idiomatic project test patterns as violations. This wastes reviewer time triaging irrelevant findings and reduces trust in automated review output. Confidence: high — both the PR author and the qodo bot itself confirmed the staleness. No qodo configuration file (.qodo.toml, .pr_agent.toml, or similar) currently exists in the repository, so the default convention rules are being applied uncustomized.
Proposed change
Add a qodo configuration file (e.g., .pr_agent.toml or .qodo.toml per qodo's current config format) to the repository root that either disables TC-001/TC-002 or replaces them with rules that match the project's actual Go testing conventions. If the convention pack is managed via qodo's admin interface rather than a repo-level config file, update it there and document the convention pack version in a comment in AGENTS.md or the repo's contributing docs so drift is detectable.
Validation criteria
After the change, run qodo-code-review on a PR that adds new Go test code using the project's standard testing patterns. Verify that TC-001 and TC-002 do not appear in the findings. Check the next 5 Go PRs reviewed by qodo for false-positive test convention findings — there should be zero from the disabled rules.
Generated by retro agent from #6147
What happened
During review of PR #6147, the author (sonupreetam) noted that qodo-code-review's Go convention pack includes testify rules TC-001 and TC-002 that reference testing conventions the project does not follow. In a comment on 2026-08-13, the author raised this as a side concern, and qodo-code-review[bot] confirmed the convention pack was stale and agreed an issue should be filed. No issue was filed at that time. On this particular PR, qodo's 2 actual findings were both valid (secret leakage, reasoning token loss), but the stale convention pack creates a standing false-positive risk for future Go test PRs.
What could go better
The qodo Go convention pack encodes testing rules (TC-001, TC-002) that assume the project uses testify assertions and test suites. The project uses a different testing approach, so these rules can produce false-positive findings on new test code — flagging idiomatic project test patterns as violations. This wastes reviewer time triaging irrelevant findings and reduces trust in automated review output. Confidence: high — both the PR author and the qodo bot itself confirmed the staleness. No qodo configuration file (
.qodo.toml,.pr_agent.toml, or similar) currently exists in the repository, so the default convention rules are being applied uncustomized.Proposed change
Add a qodo configuration file (e.g.,
.pr_agent.tomlor.qodo.tomlper qodo's current config format) to the repository root that either disables TC-001/TC-002 or replaces them with rules that match the project's actual Go testing conventions. If the convention pack is managed via qodo's admin interface rather than a repo-level config file, update it there and document the convention pack version in a comment inAGENTS.mdor the repo's contributing docs so drift is detectable.Validation criteria
After the change, run qodo-code-review on a PR that adds new Go test code using the project's standard testing patterns. Verify that TC-001 and TC-002 do not appear in the findings. Check the next 5 Go PRs reviewed by qodo for false-positive test convention findings — there should be zero from the disabled rules.
Generated by retro agent from #6147