What's missing
The ReviewFinding struct in postreview.go lacks fields to track variables
that were explicitly verified or left unchecked during security review
VerifiedVariables []string (json-tagged)
UncheckedVariables []string (json-tagged)
Additionally, formatFindingComment needs to be extended to render these fields
in PR comments.
What should happen
- Add both fields to the
ReviewFinding struct with appropriate JSON tags
- Extend
formatFindingComment to include these variable lists in its output
(minimal formatting, render as-is)
Context
This change supports the structured variable enumeration feature implemented in
fullsend-ai/agents#446. The agent-side schema already produces these fields;
fullsend needs to accept and display them.
Blocks: fullsend-ai/agents#446
Impact
Without this change, fullsend-ai/agents#446 cannot be merged — fullsend
would silently drop the variable tracking data that reviewers need to see.
What's missing
The
ReviewFindingstruct inpostreview.golacks fields to track variablesthat were explicitly verified or left unchecked during security review
VerifiedVariables []string(json-tagged)UncheckedVariables []string(json-tagged)Additionally,
formatFindingCommentneeds to be extended to render these fieldsin PR comments.
What should happen
ReviewFindingstruct with appropriate JSON tagsformatFindingCommentto include these variable lists in its output(minimal formatting, render as-is)
Context
This change supports the structured variable enumeration feature implemented in
fullsend-ai/agents#446. The agent-side schema already produces these fields;
fullsend needs to accept and display them.
Blocks: fullsend-ai/agents#446
Impact
Without this change, fullsend-ai/agents#446 cannot be merged — fullsend
would silently drop the variable tracking data that reviewers need to see.