Skip to content

feat(postreview): add VerifiedVariables and UncheckedVariables fields to ReviewFinding #6233

Description

@ben-alkov

What's missing

The ReviewFinding struct in postreview.go lacks fields to track variables
that were explicitly verified or left unchecked during security review

  • VerifiedVariables []string (json-tagged)
  • UncheckedVariables []string (json-tagged)

Additionally, formatFindingComment needs to be extended to render these fields
in PR comments.

What should happen

  1. Add both fields to the ReviewFinding struct with appropriate JSON tags
  2. Extend formatFindingComment to include these variable lists in its output
    (minimal formatting, render as-is)

Context

This change supports the structured variable enumeration feature implemented in
fullsend-ai/agents#446. The agent-side schema already produces these fields;
fullsend needs to accept and display them.

Blocks: fullsend-ai/agents#446

Impact

Without this change, fullsend-ai/agents#446 cannot be merged — fullsend
would silently drop the variable tracking data that reviewers need to see.

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewReview agentfeatureFeature-category issue awaiting human prioritizationpriority/highSignificant impact, address soonsecuritySecurity threat model and related concernstriagedTriaged but awaiting human prioritizationtype/featureNew capability request

    Type

    No type

    Projects

    Status
    Todo

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions