Skip to content

refactor(analytics): remove unused property adaptlyApproved from PullRequest model #39

@supalarry

Description

@supalarry

Problem

Originally, it was added because Adaptly was approving the PR. We also did not take into the consideration that Adaptly can run into a case when it does not "approve" the PR - if it checks the target version and the user does not run Adaptly again.

Solution

Drop adaptlyApproved property from PullRequest model. Instead, for analytics check entries in DependencyUpdate where cursorVersion = targertVersion. That means that Adaptly has done it's job.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions