Skip to content

Commit cbb1db4

Browse files
Tomkessclaude
andcommitted
Add the partial turn's answer_text to the dashboard CHAT_ERROR path
The fix itself landed on #1845's branch, but this one line could not: answer_text arrives with #1839, so referencing it there would not compile. This is the first place both exist. The turn that drafts is the turn that describes the draft, so a stream that died mid-answer can still hold the text the answer assertions read -- without this, a chat fault loses it. 1787 passed, 2 skipped. ruff and ty clean; the report_skill.py formatting offender this branch had been carrying is gone with the master merge #1845 brought in. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 parent c8b044a commit cbb1db4

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

‎packages/gooddata-eval/src/gooddata_eval/core/agentic/dashboard_skill.py‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1183,6 +1183,10 @@ def _execute_single_dashboard_run(
11831183
all_tool_call_events.extend(partial.tool_call_events or [])
11841184
all_reasoning_step_events.extend(partial.reasoning_step_events or [])
11851185
steps += partial.reasoning_step_count
1186+
# Only compiles once #1839 adds answer_text, so it is not on #1845's branch.
1187+
# The turn that drafts is the turn that describes the draft, so a stream that
1188+
# died mid-answer can still hold the text the answer assertions read.
1189+
answer_text = (partial.text_response or "").strip() or render_answer_text(partial) or answer_text
11861190
exit_reason = LoopExit.CHAT_ERROR
11871191
break
11881192
agent_elapsed = time.monotonic() - agent_started

0 commit comments

Comments
 (0)