Skip to content

[Suggestion] It seems dangerous that requests api for contributor in this way #221

@currybob

Description

@currybob

Our contributor could change their name every moment.
But, Like PR #219 , if contributors change their name, API not works properly, because Promise.all returns just reject if any of Promise array rejects result.

2018-11-02 7 42 01

So now we would decide the way it reflects

2018-11-02 9 16 04

I tried this way to avoid "fast-fail-behavior" in Promise.all and it works
Please review it at #220 @gimdongwoo @thomasJang @aeei

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions