Skip to content

Commit 48e272c

Browse files
authored
Merge pull request #211 from keymanapp/maint/cherry-pick/php-84
maint: move to PHP 8.4, Apache 2.4.68 πŸ’
2 parents 5235656 + a09832d commit 48e272c

5 files changed

Lines changed: 41 additions & 53 deletions

File tree

β€Ž.htaccessβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,10 @@ php_value display_startup_errors off
2626
# Keymanweb.com 2.0 rewrite rules for Keymanweb.com 1.0 /go/lang/kbd urls
2727

2828
# Rewrite /go/lang/kbd/app[?...] to /?kmwlang=lang,kmwkbd=kbd
29-
RewriteRule "^go/([^/]+)/([^/]+)/([^?]+)(\?)?(.+)?$" "/index.php?kmwlang=$1&kmwkbd=Keyboard_$2&$5"
29+
RewriteRule "^go/([^/]+)/([^/]+)/([^?]+)(\?)?(.+)?$" "/index.php?kmwlang=$1&kmwkbd=Keyboard_$2&$5" [BCTLS]
3030

3131
# Rewrite /go/lang/kbd[?...] to /?kmwlang=lang,kmwkbd=kbd
32-
RewriteRule "^go/([^/]+)/([^?]+)(\?)?(.+)?$" "/index.php?kmwlang=$1&kmwkbd=Keyboard_$2&$4"
32+
RewriteRule "^go/([^/]+)/([^?]+)(\?)?(.+)?$" "/index.php?kmwlang=$1&kmwkbd=Keyboard_$2&$4" [BCTLS]
3333

3434
# Keymanweb.com 2.0 rewrite rules for Keymanweb.com 1.0 /lang/app.php urls
3535

β€ŽDockerfileβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# syntax=docker/dockerfile:1
2-
FROM php:7.4-apache@sha256:c9d7e608f73832673479770d66aacc8100011ec751d1905ff63fae3fe2e0ca6d AS composer-builder
2+
FROM php:8.4-apache@sha256:51da594c844a97f31b1cd6b1ac6660982f40788f4fe13e75f7fd39e2f9b58651 AS composer-builder
33

44
# Install Zip to use composer
55
RUN apt-get update && apt-get install -y \
@@ -18,7 +18,7 @@ COPY composer.* /composer/
1818
RUN composer install
1919

2020
# Site
21-
FROM php:7.4-apache@sha256:c9d7e608f73832673479770d66aacc8100011ec751d1905ff63fae3fe2e0ca6d
21+
FROM php:8.4-apache@sha256:51da594c844a97f31b1cd6b1ac6660982f40788f4fe13e75f7fd39e2f9b58651
2222
COPY resources/keyman-site.conf /etc/apache2/conf-available/
2323
RUN cp /usr/local/etc/php/php.ini-production /usr/local/etc/php/php.ini
2424
RUN chown -R www-data:www-data /var/www/html/

β€Žbuild.shβ€Ž

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@ builder_describe \
3030
start \
3131
stop \
3232
test \
33+
"composer-start Start a temporary container to maintain composer" \
34+
"composer-stop Stop and cleanup temporary container for maintaining composer" \
3335
"--no-unit-test" \
3436
"--no-lint" \
3537
"--no-link-check"
@@ -43,3 +45,6 @@ builder_run_action build build_docker_container $KEYMANWEB_IMAGE_NAME $KEYM
4345
builder_run_action start start_docker_container $KEYMANWEB_IMAGE_NAME $KEYMANWEB_CONTAINER_NAME $KEYMANWEB_CONTAINER_DESC $HOST_KEYMANWEB_COM $PORT_KEYMANWEB_COM $BUILDER_CONFIGURATION
4446

4547
builder_run_action test test_docker_container $KEYMANWEB_CONTAINER_DESC $PORT_KEYMANWEB_COM /
48+
49+
builder_run_action composer-start docker_build_and_start_composer_container
50+
builder_run_action composer-stop docker_stop_and_cleanup_composer_container

β€Žcomposer.jsonβ€Ž

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@
33
"require": {
44
"sentry/sdk": "^3.1"
55
},
6-
"require-dev": {
7-
"phpunit/phpunit": "^9.2"
8-
},
96
"config": {
107
"allow-plugins": false
8+
},
9+
"require-dev": {
10+
"phpunit/phpunit": "^9.6"
1111
}
1212
}

β€Žcomposer.lockβ€Ž

Lines changed: 29 additions & 46 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
Β (0)