Eloquent/Collection: Call to a member function getKey() on string

[LastDragon-ru]

The following code works fine when collection contains models but will fail if Collection is empty :

(new \Illuminate\Database\Eloquent\Collection())->map(fn() => 'converts item to string')->intersect(['a']);

Maybe map() it should return base collection if empty?

framework/src/Illuminate/Database/Eloquent/Collection.php

Lines 361 to 363 in 95ce178

	return $result->contains(function ($item) {
	return ! $item instanceof Model;
	}) ? $result->toBase() : $result;

PS: Laravel v9.17.0

[mattford]

Still the case in Laravel 12.

Ran into this issue with mapWithKeys and I agree with you it should map into a base collection in the empty case, otherwise behaviour is different based on whether a query returned results or not.

Also if the collection is empty I don't expect the Eloquent specific methods would be that useful.

However this would be a BC break for that reason I don't expect it to change, workaround is to call toBase() when you need to be absolutely sure it's a base collection