TPT-4285: Implement integration tests for ReservedIP for IPv4#688
Open
mawilk90 wants to merge 30 commits into
Conversation
mawilk90
added
new-feature
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mawilk90
added
the
do-not-merge
mawilk90
requested review from
a team,
Copilot,
dawiddzhafarov and
mgwoj
and removed request for
a team
mawilk90
requested review from
a team and
zliang-akamai
and removed request for
a team and
dawiddzhafarov
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands the integration test suite for the SDK's Reserved IPv4 support, covering the new networking APIs plus cross-resource flows where reserved addresses can be tagged or attached to Linodes and NodeBalancers. It fits into the codebase by adding end-to-end coverage around the Reserved IP models and helpers that were recently added to the client, and it is explicitly stacked on top of linked PR #687.
Changes:
- Adds shared integration fixtures for creating reserved IPs and reserved IPs assigned to a Linode.
- Adds networking integration tests for reserved IP create/update/assign/allocate/type-conversion flows.
- Adds cross-resource reserved IP coverage for tags, NodeBalancers, Linode allocation, and interface-based instance creation.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
test/integration/conftest.py |
Adds reusable fixtures for creating standalone and assigned Reserved IPv4 addresses. |
test/integration/models/networking/test_networking.py |
Adds the main Reserved IPv4 integration coverage and shared assertion helpers. |
test/integration/models/nodebalancer/test_nodebalancer.py |
Adds NodeBalancer creation coverage using a reserved IPv4 address. |
test/integration/models/linode/test_linode.py |
Adds coverage for attaching an existing reserved IPv4 to a Linode. |
test/integration/models/linode/interfaces/test_interfaces.py |
Adds reserved IPv4 coverage for both legacy and Linode interface-generation instance creates. |
test/integration/models/tag/test_tag.py |
Adds tag retrieval coverage for reserved IPv4 tagged objects. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mawilk90
force-pushed
the
feature/TPT-4285-python-sdk-implement-integration-tests-for-reserved-ip-for-ipv4
branch
from
b6cff8d to
4b0f363
Compare
mawilk90
changed the title
…e#695) Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 4 to 5. - [Release notes](https://github.com/actions/dependency-review-action/releases) - [Commits](actions/dependency-review-action@v4...v5) --- updated-dependencies: - dependency-name: actions/dependency-review-action dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
mawilk90
removed
the
do-not-merge
# Conflicts: # conftest.py # linode_api4/groups/networking.py # linode_api4/groups/tag.py # linode_api4/objects/networking.py # test/unit/groups/networking_test.py
mawilk90
force-pushed
the
feature/TPT-4285-python-sdk-implement-integration-tests-for-reserved-ip-for-ipv4
branch
from
4b0f363 to
b9ca4cf
Compare
…lement-integration-tests-for-reserved-ip-for-ipv4
psnoch-akamai
approved these changes
Jun 2, 2026
| linode_ips[0].assigned_entity.url == f"/v4/linode/instances/{linode.id}" | ||
| ) | ||
|
|
||
| linode.delete() |
Member
There was a problem hiding this comment.
Can we use fixture pattern to ensure the Linode is deleted even if the test failed?
Contributor
Author
There was a problem hiding this comment.
Hi @zliang-akamai , in this case linode.delete() is used as a part of the test logic (linode.delete() impacts the reserved IPs list for further assertions). To avoid refactoring the whole test I can use try-finally, to be sure that linode.delete() is executed even if there is any failing assertion before, for example:
linode = create_linode_fn(client, reserved_ip, label, e2e_test_firewall)
try:
linode_ips = linode.ips.ipv4.public
assert len(linode_ips) == 1
assert linode_ips[0].address == reserved_ip.address
[...]
finally:
linode.delete()
Does it make sense?
Member
There was a problem hiding this comment.
Yes, that will work too I think.
Member
There was a problem hiding this comment.
And I am wondering if we can implement a context manager for use case like this. (optional, but it's something fun in Python world)
Contributor
Author
There was a problem hiding this comment.
Yes, I checked and context manager also works here. However, I decided to use simple try-finally as it is more readable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Integration tests for Reserved IPs
Required tags specified in Jira ticket.
✔️ How to Test
make test-int TEST_ARGS="-k reserved_ip -v"make test-int TEST_ARGS="-k reserve_ephemeral -v"