Skip to content

Commit 3f72803

Browse files
chore(internal): make test_proxy_environment_variables more resilient to env
1 parent 035d6a0 commit 3f72803

1 file changed

Lines changed: 14 additions & 2 deletions

File tree

‎tests/test_client.py‎

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -937,8 +937,14 @@ def retry_handler(_request: httpx.Request) -> httpx.Response:
937937
def test_proxy_environment_variables(self, monkeypatch: pytest.MonkeyPatch) -> None:
938938
# Test that the proxy environment variables are set correctly
939939
monkeypatch.setenv("HTTPS_PROXY", "https://example.org")
940-
# Delete in case our environment has this set
940+
# Delete in case our environment has any proxy env vars set
941941
monkeypatch.delenv("HTTP_PROXY", raising=False)
942+
monkeypatch.delenv("ALL_PROXY", raising=False)
943+
monkeypatch.delenv("NO_PROXY", raising=False)
944+
monkeypatch.delenv("http_proxy", raising=False)
945+
monkeypatch.delenv("https_proxy", raising=False)
946+
monkeypatch.delenv("all_proxy", raising=False)
947+
monkeypatch.delenv("no_proxy", raising=False)
942948

943949
client = DefaultHttpxClient()
944950

@@ -1833,8 +1839,14 @@ async def test_get_platform(self) -> None:
18331839
async def test_proxy_environment_variables(self, monkeypatch: pytest.MonkeyPatch) -> None:
18341840
# Test that the proxy environment variables are set correctly
18351841
monkeypatch.setenv("HTTPS_PROXY", "https://example.org")
1836-
# Delete in case our environment has this set
1842+
# Delete in case our environment has any proxy env vars set
18371843
monkeypatch.delenv("HTTP_PROXY", raising=False)
1844+
monkeypatch.delenv("ALL_PROXY", raising=False)
1845+
monkeypatch.delenv("NO_PROXY", raising=False)
1846+
monkeypatch.delenv("http_proxy", raising=False)
1847+
monkeypatch.delenv("https_proxy", raising=False)
1848+
monkeypatch.delenv("all_proxy", raising=False)
1849+
monkeypatch.delenv("no_proxy", raising=False)
18381850

18391851
client = DefaultAsyncHttpxClient()
18401852

0 commit comments

Comments
 (0)