make every inline regex usage a constant

[SuperchupuDev]

it looks like the codebase is full of inline regex usage that looks like this:

we should prefer defining regular expressions at module scope to avoid re-compilation on every function call

[jonschlinkert]

full of inline regex usage that looks like this

That might be a bit of an exaggeration. https://github.com/micromatch/picomatch/blob/master/lib/constants.js#L10-L98

we should prefer defining regular expressions at module scope to avoid re-compilation on every function call

This is something I've benchmarked exhaustively. v8 has optimizations for /foo/ versus new RegExp('foo') and I've even created libraries that do nothing but cache regular expressions for this purpose but didn't think it was necessary here because I didn't see any performance improvements.

However, I'm all for consistency in the code and would welcome a PR.

[SuperchupuDev]

That might be a bit of an exaggeration.

sorry, i just saw a few instances on the vscode search tab and assumed a lot more occurrences than what they actually were!! i did not mean to underappreciate the performance work done on this project

This is something I've benchmarked exhaustively. v8 has optimizations for /foo/ versus new RegExp('foo') and I've even created libraries that do nothing but cache regular expressions for this purpose but didn't think it was necessary here because I didn't see any performance improvements.

just for clarity i am not talking about RegExp(), i'm talking about

const test = (a) => /hello/.test(a);

versus

const REGEX = /hello/;

const test = (a) => REGEX.test(a);

a few months ago i saw picomatch spending some time compiling the same regexes multiple times while i was using regex-doctor, you might be interested in the tool for regex perf stuff :)