Fix editorconfig helper lint

Author: Colengms

Extension/src/LanguageServer/includeCleanupEditorConfig.ts

@@ -7,7 +7,10 @@ export interface IncludeCleanupPreferences {
 
 function getStringSetting(settings: any, key: string): string {
     const value: unknown = settings?.[key];
-    return typeof value === 'string' && value.toLowerCase() !== 'unset' ? value : '';
+    if (typeof value !== 'string' || value.toLowerCase() === 'unset') {
+        return '';
+    }
+    return value;
 }
 
 export function getIncludeCleanupPreferences(settings: any): IncludeCleanupPreferences {
@@ -17,4 +20,4 @@ export function getIncludeCleanupPreferences(settings: any): IncludeCleanupPrefe
         replacementFiles: getStringSetting(settings, 'cpp_include_cleanup_replacement_files'),
         requiredFiles: getStringSetting(settings, 'cpp_include_cleanup_required_files')
     };
-}
+}

Extension/test/unit/includeCleanupEditorConfig.test.ts

@@ -17,7 +17,7 @@ describe('Include Cleanup editorconfig settings', () => {
         });
     });
 
-    it('ignores unset and non-string values', () => {
+    it('maps unset and non-string values to empty strings', () => {
         deepStrictEqual(getIncludeCleanupPreferences({
             cpp_include_cleanup_alternate_files: 'unset',
             cpp_include_cleanup_excluded_files: true,
@@ -29,4 +29,4 @@ describe('Include Cleanup editorconfig settings', () => {
             requiredFiles: ''
         });
     });
-});
+});