Checklist
Describe the bug
RecomputeInProgress checked for false and then immediately assigned false
Code snips
|
if (CS_AppData.HkPacket.Payload.RecomputeInProgress == false && |
|
CS_AppData.HkPacket.Payload.OneShotInProgress == false) |
|
{ |
|
/* There is no child task running right now, we can use it*/ |
|
CS_AppData.HkPacket.Payload.RecomputeInProgress = false; |
|
if (CS_AppData.HkPacket.Payload.RecomputeInProgress == false && |
|
CS_AppData.HkPacket.Payload.OneShotInProgress == true) |
|
{ |
|
Status = CFE_ES_DeleteChildTask(CS_AppData.ChildTaskID); |
|
|
|
if (Status == CFE_SUCCESS) |
|
{ |
|
CS_AppData.ChildTaskID = CFE_ES_TASKID_UNDEFINED; |
|
CS_AppData.HkPacket.Payload.RecomputeInProgress = false; |
Expected behavior
Remove redundant assignment to simplify function.
Reporter Info
Avi Weiss @thnkslprpt
Checklist
Describe the bug
RecomputeInProgresschecked forfalseand then immediately assignedfalseCode snips
CS/fsw/src/cs_cmds.c
Lines 455 to 459 in f958cc0
CS/fsw/src/cs_cmds.c
Lines 526 to 534 in f958cc0
Expected behavior
Remove redundant assignment to simplify function.
Reporter Info
Avi Weiss @thnkslprpt