Skip to content

path_tracking_pid::PidConfig config_ should be decoupled from dynamic reconfigure #129

@Timple

Description

@Timple

dynamic reconfigure is an implementation of ROS which happens to use a large struct for its parameters.

However some of these we don't like to have dynamically reconfigurable.

I propose to have an own struct with the parameters. And let the path_tracking_pid::PidConfig config be local to the reconfigure callback. In this callback we can (if approved) set the controller parameters with setters.

This might allow to switch to ddynamic_reconfigure (if we want to). Also allows for easier ROS2 transition in the future (it uses a different method for dynamic reconfigure behavior).

Metadata

Metadata

Assignees

No one assigned

    Labels

    refactorRefactor request

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions