Commit 2b50bbd
objectui#3569 split `date` / `datetime` / `time` into three distinct inline-grid
controls. The `datetime` half got a long-lived showcase fixture
(`showcase_expense_line.incurred_at`); the `time` half got only unit tests, so
no running app has ever exercised the grid's time control.
Adds `showcase_invoice_line.service_start` (type `time`, seeded `09:15` on the
T&M service lines) and — crucially — declares the grid's `inlineColumns`
explicitly.
The explicit declaration is the point, not decoration. This line had exactly six
editable fields, i.e. exactly `DEFAULT_MAX_INLINE_COLUMNS`. A seventh column
makes auto-derivation curate, and the column that loses the tie-break is
`receipt` (a `file` column, unranked in the fill-priority table, so it sorts
last) — objectui#2360's upload-in-grid fixture. Demoting it into the column
chooser is exactly the cost that kept `time` out of objectui#3569. Declaring the
set routes through `hydrateColumns`, which never sets `defaultHidden`, so all
seven columns stay default-visible and `receipt` keeps its visibility.
Measured in the running app (showcase on a private port + DB, console built at
the pinned .objectui-sha):
before: Product | Description | Qty | Unit Price | Receipt | Amount
after: Product | Description | Service Start | Qty | Unit Price | Receipt | Amount
`Service Start` renders as a native time control; the seeded 09:15 reads back as
09:15 AM, and a value typed into an empty cell survived save + reopen.
`service_start` is translated at birth (en + zh-CN) and only that field, because
check-i18n-coverage freezes the example's untranslated count in both directions
— the same rule the `incurred_at` fixture documented.
Claude-Session: https://claude.ai/code/session_01Jqe56GnYFddggeAyfkZFVz
Co-authored-by: Claude <noreply@anthropic.com>
1 parent 91d09be commit 2b50bbd
3 files changed
Lines changed: 89 additions & 2 deletions
File tree
- examples/app-showcase/src
- data
- objects
- seed
- system/translations
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
185 | 185 | | |
186 | 186 | | |
187 | 187 | | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
188 | 222 | | |
189 | 223 | | |
190 | 224 | | |
| |||
211 | 245 | | |
212 | 246 | | |
213 | 247 | | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
214 | 271 | | |
215 | 272 | | |
216 | 273 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
383 | 383 | | |
384 | 384 | | |
385 | 385 | | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
386 | 396 | | |
387 | 397 | | |
388 | 398 | | |
389 | 399 | | |
390 | | - | |
| 400 | + | |
391 | 401 | | |
392 | 402 | | |
393 | 403 | | |
394 | | - | |
| 404 | + | |
395 | 405 | | |
396 | 406 | | |
397 | 407 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
140 | 140 | | |
141 | 141 | | |
142 | 142 | | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
143 | 156 | | |
144 | 157 | | |
145 | 158 | | |
| |||
444 | 457 | | |
445 | 458 | | |
446 | 459 | | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
447 | 467 | | |
448 | 468 | | |
449 | 469 | | |
| |||
0 commit comments