Repository navigation
Commit 2efd903
docs(plugin-webhooks): sys_webhook text says a row is an authored subscription and a declared webhook is not a row (#27787)
domain:server#2 · os-sales · session_01L6bhgUCizoYWQVJWjhdR6F
<!-- claude-projects-attribution: {"github_login":"os-sales"} -->
_Requested by **Sales** · [project
thread](https://claude.ai/code/project/chan_01D5bWFY3rFzgJcytD5gD4Uu?thread=cmsg_01D5bWFY3rFzgJcytD5gD4UuPMZ8BHWtPf6nBTp51qSM64)_
Fixes #27607
Clause-②: no
Metadata-protocol: none
Skills-docs: none — text-only description change; no authorable key,
value or meaning moves
domain:server#2 · os-sales · session_01L6bhgUCizoYWQVJWjhdR6F
## 维护者速读
- 改了什么:`sys_webhook` 对象说明、`managed_by` 与 `customized`
两个字段的帮助文字改写为现行模型:数据行是组织在 Studio 或 API 中编写的订阅;代码中声明的 webhook
从元数据注册表读取,不写入任何行。英文翻译由生成器重写,zh-CN / ja-JP / es-ES 三条译文同步重译。
- 为什么改:旧文字仍说声明的 webhook「启动时物化为数据行」,而 ADR-0131 D2 已退役该启动种入器,Setup/Studio
用户读到的是错误说明。
- 风险与回滚:仅文字,无行为、字段或选项变化;回滚即 revert 本 PR。
- 先看:`packages/plugins/plugin-webhooks/src/sys-webhook.object.ts`(对象
description 与两个字段
description)、`packages/plugins/plugin-webhooks/src/translations/zh-CN.objects.generated.ts`(重译三条)、`.changeset/27607-sys-webhook-text.md`。
- 两分钟验证:`node scripts/check-i18n-bundles.mjs --filter=webhooks`(需先 build
CLI),预期 `in sync`;`git grep -n "materialized into rows on boot"`
在源码与翻译中零命中。
- 需要你做的:无,席位落地。
## What changes
- `sys_webhook.description`: a row is an outbound subscription an
organization authors in the Studio editor or through the API; a webhook
declared with `defineStack({ webhooks })` / `defineWebhook()` is read
from the metadata registry and writes no row here (ADR-0131 D2, anchored
in a code comment beside the text). The file's top docblock was already
correct and is unchanged.
- `managed_by` field description: `admin` = created in Setup or through
the API; `package` = a copy the retired 18.0 boot seeder wrote, which
nothing writes now; `platform` = reserved. The enum values are
unchanged. Measured: no writer sets `managed_by: 'package'` or
`'platform'` on a `sys_webhook` row on this tree (the seeder
`bootstrapDeclaredWebhooks` is retired; `isSeededProvenance` only reads
the values).
- `customized` field description (bounded in-place fix, same file, same
defect class): it said "boot seeding will no longer overwrite the row",
the same retired model. It now says the ownership ceremony reads it (an
edited copy under a declared name is kept as a clone, a pristine one
deleted), matching `webhook-provenance.ts`.
- Translations: `en.objects.generated.ts` regenerated by `node
scripts/check-i18n-bundles.mjs --write --filter=webhooks` (no other
package's bundle was written). The generator's merge keeps an existing
translated value even when its source changes, so the zh-CN, ja-JP and
es-ES strings for these three texts were re-translated by hand
(AGENTS.md allows editing translated-locale values; no key added or
dropped), then the generator was re-run and kept them. No source-hash
entry covers these leaves.
- Changeset: `@objectstack/plugin-webhooks` patch.
## Tests
Text-only: no new behaviour test; no existing test or snapshot pins the
old sentences.
<details><summary>plugin-webhooks test + typecheck (head
2b0c160)</summary>
```
Test Files 24 passed (24)
Tests 252 passed (252)
TEST=0 TC=0
```
</details>
## Acceptance notes
- No other copy of the retired sentence in `content/docs/**` or other
packages; `packages/plugins/plugin-webhooks/CHANGELOG.md` mentions
`managed_by: 'package'` rows in released entries, which describe their
own release and are release-owned.
- No open PR touches `packages/plugins/plugin-webhooks/**` (read across
the 34 open PRs), so no merge-tree probe applies.
## Verification
<details><summary>Gates (head 2b0c160)</summary>
- `node scripts/pm/dispatch-gates.mjs --commands --repo
objectstack-ai/objectstack`: 55 commands, all run; 54 exit 0.
- `pnpm check:dual-build-cjs-loads` exit 3, PREREQUISITE NOT MET (needs
a full workspace build; only the CLI and plugin closures were built) —
NOT MEASURED locally, CI runs it.
- `--ran` reconciliation: 55 derived, 54 run, 1 NOT-MEASURED, 0 UNRUN.
- `node scripts/check-i18n-bundles.mjs` exit 0: all bundles in sync, 10
packages.
- `eslint --no-inline-config packages/plugins/plugin-webhooks` exit 0.
</details>
---
_Generated by [Claude
Code](https://claude.ai/code/session_01L6bhgUCizoYWQVJWjhdR6F)_
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_01L6bhgUCizoYWQVJWjhdR6F
---------
Co-authored-by: Claude <noreply@anthropic.com>1 parent cb074ec commit 2efd903
6 files changed
Lines changed: 34 additions & 17 deletions
File tree
- .changeset
- packages/plugins/plugin-webhooks/src
- translations
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
57 | 60 | | |
58 | 61 | | |
59 | 62 | | |
| |||
283 | 286 | | |
284 | 287 | | |
285 | 288 | | |
286 | | - | |
287 | | - | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
288 | 292 | | |
289 | 293 | | |
290 | 294 | | |
| |||
295 | 299 | | |
296 | 300 | | |
297 | 301 | | |
298 | | - | |
299 | | - | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
300 | 305 | | |
301 | 306 | | |
302 | 307 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
84 | | - | |
| 84 | + | |
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
| |||
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
93 | | - | |
| 93 | + | |
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
84 | | - | |
| 84 | + | |
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
| |||
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
93 | | - | |
| 93 | + | |
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
84 | | - | |
| 84 | + | |
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
| |||
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
93 | | - | |
| 93 | + | |
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
84 | | - | |
| 84 | + | |
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
| |||
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
93 | | - | |
| 93 | + | |
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
| |||
0 commit comments