Skip to content

Commit 30aae6a

Browse files
hotlongclaude
andcommitted
docs(qa): re-anchor the dead tracker citations in packages/qa to the commits that decided them
Twelve comment sites under packages/qa/*/src cited six tracker numbers that now answer 404. Each now cites the commit in this repository's history that decided what the line describes (ADR-0122 stays beside its phase-2 commit), and keeps saying in its own words what it decided. Comment lines only; every touched file keeps its line count. Claude-Session: https://claude.ai/code/session_local_1d2a197c-c20e-4e90-9be8-413d4d432289 Co-authored-by: Claude <noreply@anthropic.com>
1 parent 679f95e commit 30aae6a

5 files changed

Lines changed: 12 additions & 12 deletions

File tree

‎packages/qa/downstream-contract/src/additional-domains.fixtures.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
// README.
99
//
1010
// The annotations moved from `XInput` to the BARE name in protocol 17
11-
// (ADR-0122 phase 2, #6083) and that is not an exception to the freeze — it is
11+
// (ADR-0122 phase 2, commit 53068c130) and that is not an exception to the freeze — it is
1212
// the freeze working. These fixtures pin the AUTHOR state; phase 2 moved the
1313
// author state onto the bare name and retired `XInput` as a synonym of it, so
1414
// keeping `XInput` here was not an option and switching to it was not a choice.
@@ -130,7 +130,7 @@ export const DcMapping: Mapping = {
130130
fieldMapping: [{ source: 'Name', target: 'name', transform: 'none' }],
131131
};
132132

133-
// `DcTheme` left with `ThemeSchema` (#10485, ADR-0049 — the theme authoring
133+
// `DcTheme` left with `ThemeSchema` (commit 35ad101bc, ADR-0049 — the theme authoring
134134
// surface is retired; the freeze pins author state against a LIVE surface, and
135135
// this one no longer exists).
136136

‎packages/qa/http-conformance/src/adapter.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ import type { HttpResponseObserver } from '@objectstack/core';
2929
* - **`getPort()`**: used by boot code/tests to discover the OS-assigned
3030
* port after `listen(0)`.
3131
*
32-
* Since #6143 it also implements the contract's optional
32+
* Since commit 12298c7d6 it also implements the contract's optional
3333
* {@link NodeHttpServer.setFallbackHandler} — see the CONTRACT there. That is
3434
* NOT a third soft extension: the member is part of `IHttpServer` and carries
3535
* four testable guarantees, and this adapter has to satisfy them before the
@@ -186,7 +186,7 @@ export class NodeHttpServer implements IHttpServer {
186186
* Install the LAST-RESORT handler — see the CONTRACT on
187187
* `IHttpServer.setFallbackHandler` in `@objectstack/spec/contracts`
188188
* (#5040 §1-C). `node:http` ships no not-found hook to map onto, so this
189-
* adapter builds the equivalent out of its own router (#6143). The four
189+
* adapter builds the equivalent out of its own router (commit 12298c7d6). The four
190190
* guarantees, and how each is honoured HERE:
191191
*
192192
* 1. **Only after every registered route has missed.** The handler is a
@@ -254,7 +254,7 @@ export class NodeHttpServer implements IHttpServer {
254254
* an accurate `Allow` when the path exists under another verb, otherwise
255255
* the shared 404 body.
256256
*
257-
* Extracted from {@link handleRequest} by #6143 because it gained a second
257+
* Extracted from {@link handleRequest} by commit 12298c7d6 because it gained a second
258258
* call site: the fall-through after an installed fallback declined to
259259
* answer. Both paths must produce the byte-identical answer — a fallback
260260
* that writes nothing may not cost a caller the `Allow` header.
@@ -343,7 +343,7 @@ export class NodeHttpServer implements IHttpServer {
343343
}
344344
});
345345
}
346-
// The LAST-RESORT seam (#6143): consulted ONLY here, i.e. only once
346+
// The LAST-RESORT seam (commit 12298c7d6): consulted ONLY here, i.e. only once
347347
// every explicitly registered route has missed — see the CONTRACT on
348348
// {@link setFallbackHandler}. Resolved BEFORE the request body is read
349349
// so an unmatched request on a server with NO fallback installed still

‎packages/qa/http-conformance/src/fallback-seam.conformance.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Copyright (c) 2026 ObjectStack. Licensed under the Apache-2.0 license.
22

33
/**
4-
* `IHttpServer.setFallbackHandler` — cross-adapter conformance (#6143).
4+
* `IHttpServer.setFallbackHandler` — cross-adapter conformance (commit 12298c7d6).
55
*
66
* The contract (`packages/spec/src/contracts/http-server.ts`, #5040 §1-C)
77
* makes four testable promises, and until this file the conformance package
@@ -24,7 +24,7 @@
2424
*
2525
* Every case here runs against BOTH adapters over a real socket: the
2626
* zero-dependency `NodeHttpServer` (this package's reference implementation,
27-
* which gained the member for this suite — #6143) and `HonoHttpServer` (the
27+
* which gained the member for this suite — commit 12298c7d6) and `HonoHttpServer` (the
2828
* primary adapter). A Hono-only conditional case would prove nothing about
2929
* cross-adapter agreement, which is the entire point of this package.
3030
*/

‎packages/qa/http-conformance/src/query-multiplicity.conformance.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@
7373
* `fallback-seam.conformance.test.ts`) repeated a parameter at all.
7474
*
7575
* Consumer-side tests do not cover it either: `packages/rest`'s
76-
* `package-routes-query-multiplicity.test.ts` (#6307) hand-constructs
76+
* `package-routes-query-multiplicity.test.ts` (commit 293476148) hand-constructs
7777
* `query: { version: [...] }` and drives the handler directly, so it asserts a
7878
* shape no adapter is obliged to produce. A hand-built double can produce
7979
* anything, which is precisely why that suite stayed green while the adapters
@@ -293,7 +293,7 @@ describe('node ↔ hono: the repeated-parameter answer no longer depends on whic
293293
});
294294

295295
it('hands a consumer the SAME operand on either adapter — the ambiguity is visible, not collapsed', async () => {
296-
// Why the shape agreement is not cosmetic: this is the read #6307
296+
// Why the shape agreement is not cosmetic: this is the read commit 293476148
297297
// found on `DELETE /api/v1/packages/:id`, where a truthy single
298298
// `version` silently narrowed a destructive operation's scope. Before
299299
// route 2 the operand differed by server — `'1.0.0'` on Hono, an ARRAY

‎packages/qa/vitest-filter-preflight/src/index.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
/**
44
* A vitest FILE FILTER that selects nothing must say so — even when the rest
5-
* of the same run selects something (#17853, #17978).
5+
* of the same run selects something (commit 08f5f0e5a, #17978).
66
*
77
* ## The defect this closes, and the half vitest already covers
88
*
@@ -270,7 +270,7 @@ export function testFilesUnder(root: string): string[] {
270270
* other seven: its `Populations` is a record of CONCRETE paths and a glob
271271
* pattern cannot be a member of one. `packages/cli` satisfies the concrete-path
272272
* contract only as a by-product of a tier walk it already performed for
273-
* unrelated reasons (#13504 / #14554), so it passes its two exact arrays to
273+
* unrelated reasons (commit 44813ba57 / #14554), so it passes its two exact arrays to
274274
* `runFilterPreflight` directly and never calls this function.
275275
*
276276
* The exact project's population is `L` itself — exact, not a superset, because

0 commit comments

Comments
 (0)