Commit bfe3abc
committed
Merge branch 'main' into claude/issue-18224-wire-issue-citations-to-ci
PR #19225 made the half-state patrol callable: the patrol's steps now live in
the composite action `.github/actions/half-state-patrol`, and the workflow
`uses:` it. This branch adds the report-only `--census` leg of the citation
gate to the OLD shape, so the two sides overlapped in two places.
Conflict 1 (`on.pull_request.paths` + the `permissions:` note) is additive in
both directions: the branch's `scripts/check-issue-citations.mjs` trigger row
and main's `.github/actions/half-state-patrol/**` glob name different files,
and main's rewritten `issues: write` paragraph is kept with this branch's
`pull-requests: read` paragraph appended under it.
Conflict 2 is not textual. Main emptied that region -- every step in it moved
into the composite action -- and the census step is the one thing there that
main did not relocate. It stays a step of the CALLER, and the placement is the
argument rather than an accident:
- `scripts/check-issue-citations.mjs` is objectstack-only, so inside the
action its "Locate the patrol sources" step would either have to name it
and refuse to run in every sibling that adopted the action, or not name it
and fail on a missing file there. The repo-name gate only works in the
caller.
- The action runs its scripts from `steps.sources.outputs.root` (the tree the
action ships from) while the board's checkout is `github.workspace`. A
census of the WORKSPACE tree run from inside the action would, in a
sibling, census this repo's release pages and report the count under the
sibling's name.
- `pull-requests: read` is granted by this workflow's `permissions:` block,
which a composite action cannot carry and the action's inputs do not name.
One behaviour had to be spelled rather than inherited: the step's guard is now
`${{ !cancelled() && github.repository == '...' }}`. In the old shape the
census sat above the only step that failed the job, so it ran whatever the
sweep returned; the patrol is now one `uses:` step that goes red itself, and a
default `success()` would have skipped the census on exactly the runs where the
patrol is down. This is the guard main gave the closed-card sweep one step up,
for the reason its own comment states.
Nothing else changed: the blocking diff-scoped step in `lint.yml` and the
`OS_GATE_MERGE_GROUP_BASE_SHA` declaration are untouched, and the census
command stays a bare literal path so the gate derivation keeps seeing it.
Claude-Session: https://claude.ai/code/session_019srGWGCBBCBHqcDoRZpQRh
Co-authored-by: Claude <noreply@anthropic.com>17 files changed
Lines changed: 1227 additions & 367 deletions
File tree
- .changeset
- .github
- actions/half-state-patrol
- workflows
- content/docs/references/system
- packages
- create-objectstack/src
- metadata-protocol/src
- spec/src
- contracts
- system
- scripts
Lines changed: 15 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
21 | 34 | | |
22 | 35 | | |
| 36 | + | |
| 37 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
14 | 15 | | |
15 | 16 | | |
16 | | - | |
17 | | - | |
| 17 | + | |
| 18 | + | |
18 | 19 | | |
19 | | - | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
20 | 23 | | |
21 | 24 | | |
22 | 25 | | |
| |||
0 commit comments