Repository navigation
Commit 3c888c6
revert(app-shell): roll back objectui#11931 and objectui#11932 so the console's eager closure is under its ceiling again (objectui#11937) (#11956)
Fixes #11937
Part of #11861
Rolls back objectui#11932 (objectui#11823, seat `domain:ui#3`) as well:
measured necessary, see the report
Clause-②: no
`main` is red on `Bundle Analysis`: the console's eager closure is over
its 3,386,364-byte gzip ceiling. This PR rolls back the two Studio
changes whose strings pushed it over, so `main` returns to the tree of
f1781be, which measured under the ceiling. The route is the seat's
ruling A, under the maintainer's ruling 6056819248 step 1: `main` turns
green by rollback or plugging, and the ceiling is not raised.
Implemented by the os-dev agent of session
`https://claude.ai/code/session_01MgfduSkFrfM3eorB3UGfAU` (seat
`domain:ui#2`, claim comment 6056334737).
## What changed
- `git revert -m 1 19a7348` (objectui#11931: Studio's validation "New"
menu presets) and `git revert -m 1 f3a0488` (objectui#11932: Studio
Interfaces' page create step), one commit each.
- `.changeset/11937-eager-budget-rollback.md`, a patch for
`@object-ui/app-shell`. The two rolled-back PRs' unreleased changesets
are removed with them, so the next release does not announce what is not
in it.
- `git diff f1781be HEAD --stat` prints only
`.changeset/11937-eager-budget-rollback.md | 5 +++++`.
- Not touched: `MAX_EAGER_CLOSURE_GZIP_BYTES` and every other ceiling,
`apps/console/vite.config.ts`, `.github/**`.
## Measurement
These are local console builds (`CI=1 pnpm exec vite build` in
`apps/console`, under the container's verify lock), read from
`apps/console/dist/eager-closure.json`. The ceiling is 3,386,364 B.
| tree | eager gzip bytes | vs ceiling | eager `i18n` chunk |
|:--|--:|--:|--:|
| f1781be (objectui#11929) | 3,385,951 | −413 | 104,156 |
| 19a7348 (+ objectui#11931) | 3,386,368 | +4 | 104,569 |
| f3a0488 (+ objectui#11932, `main`) | 3,386,819 | +455 | 105,029 |
| f3a0488 − objectui#11931 only | 3,386,430 | +66 | 104,635 |
| this PR (tree = f1781be + changeset) | 3,385,951 | −413 | 104,156 |
- The 19a7348 and f3a0488 rows match CI's push runs to the 0.1 KB:
3307.0 KB, "0.0 KB over"; and 3307.4 KB, 0.4 KB over.
- Almost all of the growth is in one eager chunk, `i18n-*.js`: +413 B
from 11931 and +460 B from 11932. Every other eager chunk moved by 7 B
or less, which is minifier and hash churn.
- `chunk-membership.json` puts exactly one workspace module in that
chunk: app-shell's designer string table,
`views/metadata-admin/i18n.ts`.
- 11931's code (the preset table and the panel) is only in the lazy
`studioBuilder` chunk. Only its 12 table rows are eager.
**Why rolling back 11931 alone is not enough, and why there is no leak
to plug.**
- objectui#11932 added its own rows to the same table.
- The table's chunk is an automatic chunk. No `advancedChunks` group
matches its path, so it is not a chunk-group leak.
- 8 eager chunks import it statically:
- the register-builtins inspector path, eager by design (ruling A
6054102412, objectui#6795's order): `apps/console/src/main.tsx` →
`@object-ui/app-shell` → `views/metadata-admin/register-builtins.ts` →
`inspectors/index.ts` → `inspectors/ObjectFieldInspector.tsx` →
`metadata-admin/i18n.ts`;
- runtime surfaces: `views/ViewConfigPanel.tsx` and
`views/ReportConfigPanel.tsx` → `views/RuntimeDraftBar.tsx` →
`metadata-admin/i18n.ts`.
- Moving Studio-only rows out of that table is the lazy-loading step
objectui#6795 orders second. That is objectui#11942, not this PR.
## Verification (head `b1e82226c`)
- **Tests**, run under the lock with repo-root `pnpm exec vitest run
--maxWorkers=2 FILES`. The set is 179 files: every test file that
11932's revert touches or that imports a module either revert changes
(`interfaceCreate`, `StudioDesignSurface`, the metadata-admin i18n
table), plus the remaining `ObjectValidationsPanel*` suites and
`packages/core/src/utils/__tests__/column-identity.ratchet.test.ts`.
batch 00: 'Test Files 44 passed (44)', 'Tests 489 passed (489)'; batch
01: 'Test Files 45 passed (45)', 'Tests 631 passed (631)'; batch 02:
'Test Files 45 passed (45)', 'Tests 221 passed (221)'; batch 03: 'Test
Files 45 passed (45)', 'Tests 641 passed (641)'. Total 179 files and
1982 tests passed.
- **Type-check:** `pnpm --filter @object-ui/app-shell run type-check`
(`tsc --noEmit && tsc -p tsconfig.test.json`) exited 0. The dependency
closure was built first (`--filter '@object-ui/app-shell^...' run
build`, exit 0).
- **Gates, all exit 0:** `check:i18n-keys`,
`check:i18n-designer-parity`, `check:i18n-drift`,
`check:unreferenced-sources`, `check-changeset-presence` ("this change
declares 1 changeset(s)"), `check-changeset-no-major`,
`check:changeset-claims`, `check:pending-changeset-literals`,
`check-changeset-fixed`, `check:control-bytes`,
`check:new-line-citations`.
- **`check-changeset-overwrite`** is report-only. It lists the two
removed changesets as its case 3, superseded in the same change.
- **`pnpm exec eslint`** on the 8 touched source and test files: 0
errors and 19 react-hooks warnings. All 8 files are byte-identical to
their f1781be blobs.
- **No console build on this head**, as the PM directed: the tree is
f1781be's. CI's `Bundle Analysis` on this PR re-measures.
## os-dev report
```json
{
"issue": 11937,
"status": "done",
"branch": "claude/issue-11937-eager-closure-main-red",
"pr": "this pull request (draft; the relay forces draft)",
"session": "session_01MgfduSkFrfM3eorB3UGfAU",
"premise_still_valid": true,
"summary": "Route A, as the seat ruled under the maintainer's ruling 6056819248 step 1. objectui#11931 (19a7348) and objectui#11932 (f3a0488) are rolled back with git revert -m 1, one commit each, and an app-shell patch changeset is added. The tree equals f1781be's except for that changeset, and f1781be's tree measured 3,385,951 eager gzip bytes, 413 under the 3,386,364 ceiling. Reverting 11931 alone measured 66 B over, because 11932 added its own rows to the same eager designer table. No ceiling, chunk config or workflow is touched.",
"route": "(2) widened to A: reverting 11931 alone is insufficient (+66 B on f3a0488), and there is no leak for route (1). The designer table views/metadata-admin/i18n.ts is the only module in the automatic eager i18n chunk, and 8 eager chunks import it statically: the register-builtins inspector path (eager by design, ruling A 6054102412) and runtime surfaces (RuntimeDraftBar, RecordDetailView).",
"tests": "Head b1e8222. Union of the test files that 11932's revert touches or that import a module either revert changes (git grep of interfaceCreate, StudioDesignSurface and the metadata-admin i18n table), plus the remaining ObjectValidationsPanel suites and packages/core/src/utils/__tests__/column-identity.ratchet.test.ts: 179 files, run in 4 batches under the lock with repo-root `pnpm exec vitest run --maxWorkers=2 FILES`: batch 00: 'Test Files 44 passed (44)', 'Tests 489 passed (489)'; batch 01: 'Test Files 45 passed (45)', 'Tests 631 passed (631)'; batch 02: 'Test Files 45 passed (45)', 'Tests 221 passed (221)'; batch 03: 'Test Files 45 passed (45)', 'Tests 641 passed (641)'. Total 179 files and 1982 tests passed. No ablation applies: the change is two reverts.",
"gates": [
"app-shell type-check, `pnpm --filter @object-ui/app-shell run type-check` (echoes `tsc --noEmit && tsc -p tsconfig.test.json`) under the lock, after `pnpm --filter '@object-ui/app-shell^...' run build` (lock VERDICT command-exit 0): VERDICT command-exit 0.",
"check:i18n-keys exit 0: 'Every in-scope call-site key resolves against the en pack (3304 keys), …'",
"check:i18n-designer-parity exit 0: 'Every en row has a zh row, and every shared row carries the same placeholders.'",
"check:i18n-drift exit 0: 'Every changed designer-table en value was followed by its zh row.'",
"check:unreferenced-sources exit 0: 'OK Every shipped source file in every covered package is reachable.'",
"check-changeset-presence exit 0: '11 source file(s) of 1 released package(s) changed, and this change declares 1 changeset(s): .changeset/11937-eager-budget-rollback.md.'",
"check-changeset-no-major exit 0: 'No changeset declares a `major` bump.'",
"check:changeset-claims exit 0: 'No pending changeset names a file this change touches.'",
"check:pending-changeset-literals exit 0: 'No test source names a pending changeset.'",
"check-changeset-fixed exit 0: 'privatePackages declared: version=true, tag=false.'",
"check-changeset-overwrite exit 0, report-only: it lists the deletion of the two rolled-back PRs' unreleased changesets (11823-page-create.md, 11861-validation-presets.md). That is its case 3, superseded in the same change, and intended: the next release must not announce features that are not in it.",
"check:control-bytes exit 0; check:new-line-citations exit 0 ('0 new citation(s)').",
"eslint (`pnpm exec eslint --format json`) on the 8 touched .ts/.tsx files: exit 0, 0 errors, 19 warnings (react-hooks rules). Every file is byte-identical to its f1781be blob, so this PR adds none of them.",
"Eager closure: no console build on this head, as the PM directed. The tree equals f1781be's (git diff f1781be HEAD --stat shows only the changeset), and f1781be's build measured 3,385,951 B (local `check:eager-closure` inputs, emit-eager-closure-report line '3385951 bytes gzipped (3306.6 KB)'). CI's Bundle Analysis on this PR re-measures.",
"head: b1e8222 (git rev-parse --short HEAD after the last commit)."
],
"files_changed": [
".changeset/11937-eager-budget-rollback.md (added)",
".changeset/11861-validation-presets.md, .changeset/11823-page-create.md (deleted, the rolled-back PRs' unreleased changesets)",
"content/docs/guide/console.md",
"packages/app-shell/src/views/metadata-admin/i18n.ts",
"packages/app-shell/src/views/studio-design/ObjectValidationsPanel.tsx, validationPresets.ts (deleted), ObjectValidationsPanel.presets-11861.test.tsx (deleted), ObjectValidationsPanel.test.tsx, ObjectValidationsPanel.newRuleWaits-11820.test.tsx, ObjectValidationsPanel.whenKey.test.tsx",
"packages/app-shell/src/views/studio-design/StudioDesignSurface.tsx, interfaceCreate.tsx, interfaceCreate.test.tsx, StudioDesignSurface.interfacesCreatePage-11823.test.tsx (deleted)"
],
"deviations": [
"The PR is a draft. The PM's correction says so, and the relay forces draft anyway.",
"objectui#11932's files are outside the claim's file surface. The PM's message assigns recording that amendment to the seat.",
"The two reverts are separate commits made with `git revert -m 1 --no-commit` and then `git commit -F -`, so that each carries the model-free trailer pair. Each tree is the plain revert's.",
"There is no os-dev-report comment this round, because of the PM's write-budget instruction. The report is in this body and in the hand-back.",
"Round 1, for the record: the blocked report comment 6056966795 on the card holds the full four-build measurement."
],
"mcp_calls": "0",
"api_writes": "this round: 1 pr_create (relay) + 1 label-write for the PR assignee, after the PR exists, recorded in the hand-back. Round 1: 1 comment (6056966795). Git pushes are not REST writes.",
"open_questions": [],
"out_of_scope_findings": [
"carrier: objectui#11942 (the seat's objectui#6795-order follow-up) · the eager designer-table chunk i18n-*.js weighs 105,029 B gz on f3a0488, about 3.1% of the eager closure, and every Studio-only row added to views/metadata-admin/i18n.ts lands in it eagerly · noted, not filed"
]
}
```
---
_Generated by [Claude
Code](https://claude.ai/code/session_01MgfduSkFrfM3eorB3UGfAU)_
---------
Co-authored-by: Claude <noreply@anthropic.com>1 parent f3a0488 commit 3c888c6
15 files changed
Lines changed: 67 additions & 1396 deletions
File tree
- .changeset
- content/docs/guide
- packages/app-shell/src/views
- metadata-admin
- studio-design
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | | - | |
| 50 | + | |
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3088 | 3088 | | |
3089 | 3089 | | |
3090 | 3090 | | |
3091 | | - | |
3092 | | - | |
3093 | | - | |
3094 | | - | |
3095 | | - | |
3096 | | - | |
3097 | | - | |
3098 | | - | |
3099 | | - | |
3100 | | - | |
3101 | | - | |
3102 | | - | |
3103 | | - | |
3104 | 3091 | | |
3105 | 3092 | | |
3106 | 3093 | | |
| |||
3241 | 3228 | | |
3242 | 3229 | | |
3243 | 3230 | | |
3244 | | - | |
3245 | | - | |
| 3231 | + | |
| 3232 | + | |
3246 | 3233 | | |
3247 | 3234 | | |
3248 | 3235 | | |
| |||
3269 | 3256 | | |
3270 | 3257 | | |
3271 | 3258 | | |
3272 | | - | |
3273 | | - | |
3274 | | - | |
3275 | | - | |
3276 | | - | |
3277 | | - | |
3278 | | - | |
3279 | | - | |
3280 | | - | |
3281 | | - | |
3282 | | - | |
3283 | | - | |
3284 | | - | |
3285 | | - | |
3286 | 3259 | | |
3287 | 3260 | | |
3288 | 3261 | | |
| |||
6247 | 6220 | | |
6248 | 6221 | | |
6249 | 6222 | | |
6250 | | - | |
6251 | | - | |
6252 | | - | |
6253 | | - | |
6254 | | - | |
6255 | | - | |
6256 | | - | |
6257 | | - | |
6258 | | - | |
6259 | | - | |
6260 | | - | |
6261 | | - | |
6262 | 6223 | | |
6263 | 6224 | | |
6264 | 6225 | | |
| |||
6369 | 6330 | | |
6370 | 6331 | | |
6371 | 6332 | | |
6372 | | - | |
| 6333 | + | |
6373 | 6334 | | |
6374 | 6335 | | |
6375 | 6336 | | |
| |||
6391 | 6352 | | |
6392 | 6353 | | |
6393 | 6354 | | |
6394 | | - | |
6395 | | - | |
6396 | | - | |
6397 | | - | |
6398 | | - | |
6399 | | - | |
6400 | | - | |
6401 | | - | |
6402 | | - | |
6403 | | - | |
6404 | | - | |
6405 | 6355 | | |
6406 | 6356 | | |
6407 | 6357 | | |
| |||
Lines changed: 0 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
71 | | - | |
72 | | - | |
73 | 71 | | |
74 | 72 | | |
75 | 73 | | |
| |||
0 commit comments